github-mirrors/elasticsearch
1
0
Fork 0
mirror of https://github.com/elastic/elasticsearch.git synced 2025-04-25 15:47:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix a quota-aware-fs test on Windows (#64401)

Browse source 
One of the `quota-aware-fs` plugin's tests was failing on Windows, due to a path being
constructed like `/C:/...`. Work around this using `new File()`.
This commit is contained in:
Rory Hunter 2020-10-30 11:57:18 +00:00 • committed by GitHub
parent 0e81fc641a
commit f6692ec749
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugins/quota-aware-fs/src/test/java/org/elasticsearch/fs/quotaaware/QuotaAwareFileSystemProviderTests.java
View file

@ -267,9 +267,12 @@ public class QuotaAwareFileSystemProviderTests extends LuceneTestCase {
FileSystemProvider systemProvider = quotaFile.getFileSystem().provider(); FileSystemProvider systemProvider = quotaFile.getFileSystem().provider();
DelegatingProvider cyclicProvider = new DelegatingProvider(systemProvider) { DelegatingProvider cyclicProvider = new DelegatingProvider(systemProvider) {
@Override @Override
@SuppressForbidden(reason = "Uses new File() to work around test issue on Windows")
public Path getPath(URI uri) { public Path getPath(URI uri) {
try { try {
return cyclicReference.getFileSystem(new URI("file:///")).getPath(uri.getPath()); // This convoluted line is necessary in order to get a valid path on Windows.
final String uriPath = new File(uri.getPath()).toPath().toString();
return cyclicReference.getFileSystem(new URI("file:///")).getPath(uriPath);
} catch (URISyntaxException e) { } catch (URISyntaxException e) {
throw new RuntimeException(e); throw new RuntimeException(e);
} }