mirror of
https://github.com/elastic/elasticsearch.git
synced 2025-04-23 14:47:31 -04:00
cf36d97a32
This PR addresses issues around aggregations cancellation, mentioned in https://github.com/elastic/elasticsearch/issues/108701 and other places. In brief, during aggregations collection time, we respect cancellation via the mechanisms in the searcher to poison cancelled queries. But once the aggregation finishes collection, there is no further need to interact with the searcher, so we cannot rely on that for cancellation checking. In particular, deeply nested aggregations can spend a long time constructing the results tree. Checking for cancellation is a trade off, as the check itself is somewhat expensive (it involves a volatile read), so we want to balance checking often enough that cancelled queries aren't taking up resources for a long time, but not so frequently that it slows down most aggregation queries. Our first attempt to this is to check once when we go to build sub-aggregations, as the worst cases for this that we've seen involve needing to build deep sub-aggregation trees. Checking at sub-aggregation construction time also provides a conveniently centralized method call to add the check to. --------- Conflicts: server/src/main/java/org/elasticsearch/search/aggregations/bucket/BucketsAggregator.java test/framework/src/main/java/org/elasticsearch/search/aggregations/AggregatorTestCase.java Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> |
||
|---|---|---|
| .. | ||
| 117201.yaml | ||
| 119748.yaml | ||
| 120014.yaml | ||
| 120062.yaml | ||
| 120256.yaml | ||
| 120590.yaml | ||
| 120717.yaml | ||
| 120809.yaml | ||
| 120930.yaml | ||
| 120944.yaml | ||
| 121283.yaml | ||
| 121715.yaml | ||