Updated the filter condition for notContains (#4152) (#4156)

Co-authored-by: Rajat Dabade <rajat.dabade@mattermost.com>
This commit is contained in:
Miguel de la Cruz 2022-11-07 20:24:33 +01:00 committed by GitHub
parent ae0b58b2f2
commit 806fb6754c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions

View file

@ -335,4 +335,17 @@ describe('src/cardFilter', () => {
expect(result[0]).toEqual(card1)
})
})
describe('verify applyFilter for title', () => {
test('should not return array with card1', () => {
const filterClauseNotContains = createFilterClause({propertyId: 'title', condition: 'notContains', values: ['card1']})
const filterGroup = createFilterGroup({
operation: 'and',
filters: [
filterClauseNotContains,
],
})
const result = CardFilter.applyFilterGroup(filterGroup, [], [card1])
expect(result.length).toEqual(0)
})
})
})

View file

@ -89,7 +89,7 @@ class CardFilter {
if (filter.values.length === 0) {
return true
}
return (value as string || '').includes(filter.values[0])
return !(value as string || '').includes(filter.values[0])
}
case 'startsWith': {
if (filter.values.length === 0) {