github-mirrors/ibex
1
0
Fork 0
mirror of https://github.com/lowRISC/ibex.git synced 2025-04-22 04:47:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[rtl/lsu] Rework assertion checking response valid

Browse source 
This commit replaces an obsolete assertion with one checking that
response valid is received only if the LSU is ready to handle it.

This resolves lowRISC/ibex#421 reported by @udinator.
This commit is contained in:
Pirmin Vogel 2019-10-24 16:09:21 +01:00
parent edf9371c6c
commit 36ce999fbb
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
rtl/ibex_load_store_unit.sv
View file

@ -483,18 +483,11 @@ module ibex_load_store_unit (
////////////////
`ifndef VERILATOR
// make sure there is no new request when the old one is not yet completely done
// i.e. it should not be possible to get a grant without an rvalid for the
// last request
// there should not be an rvalid unless the FSM is handlling it
assert property (
@(posedge clk_i)
((ls_fsm_cs == WAIT_RVALID) && (data_gnt_i == 1'b1)) |-> (data_rvalid_i == 1'b1) ) else
$display("Data grant set while LSU keeps waiting for rvalid");
// there should be no rvalid when we are in IDLE
assert property (
@(posedge clk_i) (ls_fsm_cs == IDLE) |-> (data_rvalid_i == 1'b0) ) else
$display("Data rvalid set while LSU idle");
@(posedge clk_i) (data_rvalid_i) |-> ((ls_fsm_cs == WAIT_RVALID) ||
(ls_fsm_cs == WAIT_RVALID_MIS) || (ls_fsm_cs == WAIT_RVALID_DONE)) ) else
$display("Data response valid received without expecting it");
// assert that errors are only sent at the same time as rvalid
assert property (