github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #7129 from ycombinator/safer-range-bound

Browse source 
Use lt instead of lte for safer upper bound in range filter.
This commit is contained in:
Spencer 2016-05-11 04:01:19 -07:00
commit 0051da439f
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ui/public/agg_types/__tests__/buckets/create_filter/date_histogram.js
View file

@ -72,13 +72,13 @@ describe('AggConfig Filters', function () {
expect(fieldParams).to.have.property('gte'); expect(fieldParams).to.have.property('gte');
expect(fieldParams.gte).to.be.a('number'); expect(fieldParams.gte).to.be.a('number');
expect(fieldParams).to.have.property('lte'); expect(fieldParams).to.have.property('lt');
expect(fieldParams.lte).to.be.a('number'); expect(fieldParams.lt).to.be.a('number');
expect(fieldParams).to.have.property('format'); expect(fieldParams).to.have.property('format');
expect(fieldParams.format).to.be('epoch_millis'); expect(fieldParams.format).to.be('epoch_millis');
expect(fieldParams.gte).to.be.lessThan(fieldParams.lte); expect(fieldParams.gte).to.be.lessThan(fieldParams.lt);
expect(filter).to.have.property('meta'); expect(filter).to.have.property('meta');
expect(filter.meta).to.have.property('index', vis.indexPattern.id); expect(filter.meta).to.have.property('index', vis.indexPattern.id);
@ -102,7 +102,7 @@ describe('AggConfig Filters', function () {
let params = filter.range[field.name]; let params = filter.range[field.name];
expect(params.gte).to.be(+bucketStart); expect(params.gte).to.be(+bucketStart);
expect(params.lte).to.be(+bucketStart.clone().add(interval).subtract(1, 'ms')); expect(params.lt).to.be(+bucketStart.clone().add(interval));
}); });
}); });
}); });

2
src/ui/public/agg_types/buckets/create_filter/date_histogram.js
View file

@ -8,7 +8,7 @@ export default function createDateHistogramFilterProvider(Private) {
return buildRangeFilter(agg.params.field, { return buildRangeFilter(agg.params.field, {
gte: start.valueOf(), gte: start.valueOf(),
lte: start.add(interval).subtract(1, 'ms').valueOf(), lt: start.add(interval).valueOf(),
format: 'epoch_millis' format: 'epoch_millis'
}, agg.vis.indexPattern); }, agg.vis.indexPattern);
}; };