github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Deangularize and euificate sidebar (#47559)

Browse source 
* Split angular templates into React components

* Add tooltip for field label

* Adapt SCSS

* Cleanup angular directives

* Extract helper functions

* Improve tests + docs

* Move css to _sidebar.scss

* Exclude _id field from displaying the Visualize button to prevent an ES error

* A11y improvements
This commit is contained in:
Matthias Wilhelm 2020-03-31 17:01:44 +02:00 • committed by GitHub
parent 4899aaf565
commit 0082ca7ad8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
63 changed files with 2005 additions and 1774 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/accessibility/apps/discover.ts
View file

@ -63,7 +63,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
});
it.skip('Click on new to clear the search', async () => {
it('Click on new to clear the search', async () => {
await PageObjects.discover.clickNewSearchButton();
await a11y.testAppSnapshot();
});
@ -121,7 +121,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
});
it.skip('Add more fields from sidebar', async () => {
it('Add more fields from sidebar', async () => {
for (const [columnName, value] of TEST_FILTER_COLUMN_NAMES) {
await PageObjects.discover.clickFieldListItem(columnName);
await PageObjects.discover.clickFieldListPlusFilter(columnName, value);