remove unused injected dependencies (3rd in a series) (#37947)

* remove unused injected dependencies

src/legacy/ui/public/courier/fetch/call_response_handlers.js

@@ -23,7 +23,7 @@ import { RequestStatus } from './req_status';
 import { SearchError } from '../search_strategy/search_error';
 import { i18n } from '@kbn/i18n';
 
-export function CallResponseHandlersProvider(Private, Promise) {
+export function CallResponseHandlersProvider(Promise) {
   const ABORTED = RequestStatus.ABORTED;
   const INCOMPLETE = RequestStatus.INCOMPLETE;
 

src/legacy/ui/public/directives/field_name.js

@@ -46,7 +46,7 @@ const compiledSourceFieldNameIcon = template(sourceFieldNameIcon);
 const compiledStringFieldNameIcon = template(stringFieldNameIcon);
 const compiledUnknownFieldNameIcon = template(unknownFieldNameIcon);
 
-module.directive('fieldName', function ($compile, $rootScope, config) {
+module.directive('fieldName', function ($rootScope, config) {
   return {
     restrict: 'AE',
     scope: {

src/legacy/ui/public/error_url_overflow/error_url_overflow.js

@@ -32,7 +32,7 @@ uiRoutes
     k7Breadcrumbs: () => [{ text: i18n.translate('common.ui.errorUrlOverflow.breadcrumbs.errorText', { defaultMessage: 'Error' }) }],
     controllerAs: 'controller',
     controller: class OverflowController {
-      constructor(Private, config, $scope) {
+      constructor(Private, $scope) {
         const kbnUrl = Private(KbnUrlProvider);
         const urlOverflow = new UrlOverflowService();
 

src/legacy/ui/public/index_patterns/route_setup/load_default.js

@@ -65,7 +65,7 @@ export default function (opts) {
   const whenMissingRedirectTo = opts.whenMissingRedirectTo || null;
 
   uiRoutes
-    .addSetupWork(function loadDefaultIndexPattern(Private, Promise, $route, config) {
+    .addSetupWork(function loadDefaultIndexPattern(Private, $route, config) {
       const getIds = Private(IndexPatternsGetProvider)('id');
       const route = _.get($route, 'current.$$route');
 

src/legacy/ui/public/routes/__tests__/_wrap_route_with_prep.js

@@ -48,7 +48,7 @@ describe('wrapRouteWithPrep fn', function () {
       let Promise;
       let $injector;
 
-      ngMock.inject(function ($rootScope, _Private_, _Promise_, _$injector_) {
+      ngMock.inject(function (_Promise_, _$injector_) {
         Promise = _Promise_;
         $injector = _$injector_;
       });

src/legacy/ui/public/state_management/app_state.js

@@ -35,7 +35,7 @@ import { callEach } from '../utils/function';
 
 const urlParam = '_a';
 
-export function AppStateProvider(Private, $rootScope, $location, $injector) {
+export function AppStateProvider(Private, $location, $injector) {
   const State = Private(StateProvider);
   const PersistedState = $injector.get('PersistedState');
   let persistedStates;

src/legacy/ui/public/style_compile/style_compile.js

@@ -27,7 +27,7 @@ const $style = $('<style>').appendTo('head').attr('id', 'style-compile');
 
 uiModules
   .get('kibana')
-  .run(function ($rootScope, $compile, config) {
+  .run(function ($rootScope, config) {
     const truncateGradientHeight = 15;
     const template = _.template(cssTmpl);
     const locals = {};

src/legacy/ui/public/url/redirect_when_missing.js

@@ -28,7 +28,7 @@ import { uiModules } from '../modules';
 uiModules.get('kibana/url')
   .service('redirectWhenMissing', function (Private) { return Private(RedirectWhenMissingProvider); });
 
-export function RedirectWhenMissingProvider($location, kbnUrl, Promise) {
+export function RedirectWhenMissingProvider(kbnUrl, Promise) {
   /**
    * Creates an error handler that will redirect to a url when a SavedObjectNotFound
    * error is thrown

src/legacy/ui/public/vis/editors/default/vis_options.js

@@ -32,7 +32,7 @@ import { I18nContext } from 'ui/i18n';
 
 uiModules
   .get('app/visualize')
-  .directive('visEditorVisOptions', function (Private, $compile) {
+  .directive('visEditorVisOptions', function ($compile) {
     return {
       restrict: 'E',
       template: visOptionsTemplate,

src/legacy/ui/public/vis/vis_types/vislib_vis_type.js

@@ -30,7 +30,7 @@ import { VisFiltersProvider } from '../vis_filters';
 import $ from 'jquery';
 import { defaultsDeep } from 'lodash';
 
-export function VislibVisTypeProvider(Private, $rootScope, $timeout, $compile) {
+export function VislibVisTypeProvider(Private, $rootScope, $compile) {
   const vislib = Private(VislibProvider);
   const visFilters = Private(VisFiltersProvider);
   const BaseVisType = Private(BaseVisTypeProvider);

x-pack/plugins/maps/public/angular/services/gis_map_saved_object_loader.js

@@ -11,7 +11,7 @@ import { SavedObjectLoader, SavedObjectsClientProvider } from 'ui/saved_objects'
 const module = uiModules.get('app/maps');
 
 // This is the only thing that gets injected into controllers
-module.service('gisMapSavedObjectLoader', function (Private, SavedGisMap, kbnIndex, kbnUrl, $http, chrome) {
+module.service('gisMapSavedObjectLoader', function (Private, SavedGisMap, kbnUrl, chrome) {
   const savedObjectClient = Private(SavedObjectsClientProvider);
   return new SavedObjectLoader(SavedGisMap, kbnUrl, chrome, savedObjectClient);
 });