github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Adding aria-label for discover data grid select document checkbox (#131277)

Browse source
This commit is contained in:
Bhavya RM 2022-05-03 15:37:23 -04:00 • committed by GitHub
parent 9d7b4590e2
commit 02c21aa1e2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/plugins/discover/public/components/discover_grid/discover_grid_document_selection.tsx
View file

@ -18,6 +18,7 @@ import {
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { euiLightVars as themeLight, euiDarkVars as themeDark } from '@kbn/ui-theme';
import { i18n } from '@kbn/i18n';
import { DiscoverGridContext } from './discover_grid_context';
import { ElasticSearchHit } from '../../types';
@ -36,6 +37,11 @@ export const SelectButton = ({ rowIndex, setCellProps }: EuiDataGridCellValueEle
const id = useMemo(() => getDocId(doc), [doc]);
const checked = useMemo(() => selectedDocs.includes(id), [selectedDocs, id]);
const toggleDocumentSelectionLabel = i18n.translate('discover.grid.selectDoc', {
defaultMessage: `Select document '{rowNumber}'`,
values: { rowNumber: rowIndex + 1 },
});
useEffect(() => {
if (expanded && doc && expanded._id === doc._id) {
setCellProps({
@ -51,7 +57,7 @@ export const SelectButton = ({ rowIndex, setCellProps }: EuiDataGridCellValueEle
return (
<EuiCheckbox
id={id}
label=""
aria-label={toggleDocumentSelectionLabel}
checked={checked}
data-test-subj={`dscGridSelectDoc-${id}`}
onChange={() => {