github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Data] Add extra logging to detect flaky test problem (#113661)

Browse source
This commit is contained in:
Michael Dokolin 2021-11-02 13:53:54 +01:00 • committed by GitHub
parent 0de567aa99
commit 02e8271e36
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/interpreter_functional/test_suites/run_pipeline/esaggs_timeshift.ts
View file

@ -12,6 +12,10 @@ import { ExpectExpression, expectExpressionProvider } from './helpers';
import { FtrProviderContext } from '../../../functional/ftr_provider_context';
function getCell(esaggsResult: any, row: number, column: number): unknown | undefined {
if (esaggsResult && !esaggsResult.columns) {
throw new Error(`Unexpected esaggs result: ${JSON.stringify(esaggsResult, undefined, ' ')}`);
}
const columnId = esaggsResult?.columns[column]?.id;
if (!columnId) {
return;
@ -37,8 +41,7 @@ export default function ({
}: FtrProviderContext & { updateBaselines: boolean }) {
let expectExpression: ExpectExpression;
// FLAKY https://github.com/elastic/kibana/issues/107028
describe.skip('esaggs timeshift tests', () => {
describe('esaggs timeshift tests', () => {
before(() => {
expectExpression = expectExpressionProvider({ getService, updateBaselines });
});
@ -98,6 +101,7 @@ export default function ({
'esaggs_shift_single_percentile',
expression
).getResponse();
// percentile is not stable
expect(getCell(result, 0, 0)).to.be.within(10000, 20000);
expect(getCell(result, 0, 1)).to.be.within(10000, 20000);