Restructure dashboard files and folders (#9969) (#9986)

* Restructure dashboard files and folders

* Try to stay DRY

avoid duplicate ‘dashboard’ naming when unnecessary

* rename index => dashboard and add an index.js with imports

rename style

* un-dig

src/core_plugins/kibana/public/dashboard/__tests__/dashboard_panels.js

@@ -1,8 +1,8 @@
 import angular from 'angular';
 import expect from 'expect.js';
 import ngMock from 'ng_mock';
-import 'plugins/kibana/dashboard/services/_saved_dashboard';
-import { DEFAULT_PANEL_WIDTH, DEFAULT_PANEL_HEIGHT } from '../components/panel/lib/panel_state';
+import 'plugins/kibana/dashboard/saved_dashboard/saved_dashboard';
+import { DEFAULT_PANEL_WIDTH, DEFAULT_PANEL_HEIGHT } from 'plugins/kibana/dashboard/panel/panel_state';
 
 describe('dashboard panels', function () {
   let $scope;

src/core_plugins/kibana/public/dashboard/grid.js

@@ -3,8 +3,8 @@ import $ from 'jquery';
 import Binder from 'ui/binder';
 import 'gridster';
 import uiModules from 'ui/modules';
-import { PanelUtils } from 'plugins/kibana/dashboard/components/panel/lib/panel_utils';
-import { getPersistedStateId } from 'plugins/kibana/dashboard/components/panel/lib/panel_state';
+import { PanelUtils } from 'plugins/kibana/dashboard/panel/panel_utils';
+import { getPersistedStateId } from 'plugins/kibana/dashboard/panel/panel_state';
 
 const app = uiModules.get('app/dashboard');
 

src/core_plugins/kibana/public/dashboard/index.js

@@ -6,19 +6,19 @@ import 'ui/config';
 import 'ui/notify';
 import 'ui/typeahead';
 import 'ui/share';
-import 'plugins/kibana/dashboard/directives/grid';
-import 'plugins/kibana/dashboard/directives/dashboard_panel';
-import 'plugins/kibana/dashboard/services/saved_dashboards';
-import 'plugins/kibana/dashboard/styles/main.less';
+import 'plugins/kibana/dashboard/grid';
+import 'plugins/kibana/dashboard/panel/panel';
+import 'plugins/kibana/dashboard/saved_dashboard/saved_dashboards';
+import 'plugins/kibana/dashboard/styles/index.less';
 import FilterBarQueryFilterProvider from 'ui/filter_bar/query_filter';
 import DocTitleProvider from 'ui/doc_title';
 import stateMonitorFactory  from 'ui/state_management/state_monitor_factory';
 import uiRoutes from 'ui/routes';
 import uiModules from 'ui/modules';
 import indexTemplate from 'plugins/kibana/dashboard/index.html';
-import { savedDashboardRegister } from 'plugins/kibana/dashboard/services/saved_dashboard_register';
-import { getTopNavConfig } from './get_top_nav_config';
-import { createPanelState } from 'plugins/kibana/dashboard/components/panel/lib/panel_state';
+import { savedDashboardRegister } from 'plugins/kibana/dashboard/saved_dashboard/saved_dashboard_register';
+import { getTopNavConfig } from './top_nav/get_top_nav_config';
+import { createPanelState } from 'plugins/kibana/dashboard/panel/panel_state';
 import { DashboardConstants } from './dashboard_constants';
 import UtilsBrushEventProvider from 'ui/utils/brush_event';
 import FilterBarFilterBarClickHandlerProvider from 'ui/filter_bar/filter_bar_click_handler';

src/core_plugins/kibana/public/dashboard/panel/panel.js

@@ -1,12 +1,12 @@
 import _ from 'lodash';
 import 'ui/visualize';
 import 'ui/doc_table';
-import 'plugins/kibana/dashboard/services/get_object_loaders_for_dashboard';
+import 'plugins/kibana/dashboard/panel/get_object_loaders_for_dashboard';
 import FilterManagerProvider from 'ui/filter_manager';
 import uiModules from 'ui/modules';
-import panelTemplate from 'plugins/kibana/dashboard/components/panel/panel.html';
-import { getPersistedStateId } from 'plugins/kibana/dashboard/components/panel/lib/panel_state';
-import { loadSavedObject } from 'plugins/kibana/dashboard/components/panel/lib/load_saved_object';
+import panelTemplate from 'plugins/kibana/dashboard/panel/panel.html';
+import { getPersistedStateId } from 'plugins/kibana/dashboard/panel/panel_state';
+import { loadSavedObject } from 'plugins/kibana/dashboard/panel/load_saved_object';
 
 uiModules
 .get('app/dashboard')

src/core_plugins/kibana/public/dashboard/panel/panel_utils.js

@@ -1,4 +1,4 @@
-import { DEFAULT_PANEL_WIDTH, DEFAULT_PANEL_HEIGHT } from 'plugins/kibana/dashboard/components/panel/lib/panel_state';
+import { DEFAULT_PANEL_WIDTH, DEFAULT_PANEL_HEIGHT } from 'plugins/kibana/dashboard/panel/panel_state';
 
 export class PanelUtils {
   /**

src/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboards.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import Scanner from 'ui/utils/scanner';
-import 'plugins/kibana/dashboard/services/_saved_dashboard';
+import 'plugins/kibana/dashboard/saved_dashboard/saved_dashboard';
 import uiModules from 'ui/modules';
 const module = uiModules.get('app/dashboard');
 import { SavedObjectLoader } from 'ui/courier/saved_object/saved_object_loader';

src/core_plugins/kibana/public/dashboard/top_nav/get_top_nav_config.js

@@ -36,7 +36,7 @@ function getAddConfig() {
     key: 'add',
     description: 'Add a panel to the dashboard',
     testId: 'dashboardAddPanelButton',
-    template: require('plugins/kibana/dashboard/partials/pick_visualization.html')
+    template: require('plugins/kibana/dashboard/top_nav/add_panel.html')
   };
 }
 
@@ -48,7 +48,7 @@ function getSaveConfig() {
     key: 'save',
     description: 'Save Dashboard',
     testId: 'dashboardSaveButton',
-    template: require('plugins/kibana/dashboard/partials/save_dashboard.html')
+    template: require('plugins/kibana/dashboard/top_nav/save.html')
   };
 }
 
@@ -60,7 +60,7 @@ function getOpenConfig() {
     key: 'open',
     description: 'Open Saved Dashboard',
     testId: 'dashboardOpenButton',
-    template: require('plugins/kibana/dashboard/partials/load_dashboard.html')
+    template: require('plugins/kibana/dashboard/top_nav/open.html')
   };
 }
 
@@ -72,7 +72,7 @@ function getShareConfig() {
     key: 'share',
     description: 'Share Dashboard',
     testId: 'dashboardShareButton',
-    template: require('plugins/kibana/dashboard/partials/share.html')
+    template: require('plugins/kibana/dashboard/top_nav/share.html')
   };
 }
 
@@ -84,6 +84,6 @@ function getOptionsConfig() {
     key: 'options',
     description: 'Options',
     testId: 'dashboardOptionsButton',
-    template: require('plugins/kibana/dashboard/partials/options.html')
+    template: require('plugins/kibana/dashboard/top_nav/options.html')
   };
 }

test/functional/apps/dashboard/_dashboard.js

@@ -2,7 +2,7 @@
 import expect from 'expect.js';
 import {
   DEFAULT_PANEL_WIDTH, DEFAULT_PANEL_HEIGHT
-} from '../../../../src/core_plugins/kibana/public/dashboard/components/panel/lib/panel_state';
+} from '../../../../src/core_plugins/kibana/public/dashboard/panel/panel_state';
 
 import {
   bdd,