github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Rollups] Surface index pattern validation errors in Rollup Job wizard. (#25078) (#25094)

Browse source 
* Show fatal error for unexpected errors.
This commit is contained in:
CJ Cenizal 2018-11-02 22:08:05 -07:00 • committed by GitHub
parent 6898032816
commit 03b6de2b10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

35
x-pack/plugins/rollup/public/crud_app/sections/job_create/job_create.js
View file

@ -26,6 +26,8 @@ import {
EuiTitle,
} from '@elastic/eui';
import { fatalError } from 'ui/notify';
import { CRUD_APP_BASE_PATH } from '../../constants';
import {
getRouterLinkProps,
@ -228,7 +230,7 @@ export class JobCreateUi extends Component {
this.onFieldsChange({
dateHistogramField: indexPatternDateFields.length ? indexPatternDateFields[0] : null,
}, STEP_DATE_HISTOGRAM);
}).catch(() => {
}).catch((error) => {
// We don't need to do anything if this component has been unmounted.
if (!this._isMounted) {
return;
@ -239,10 +241,33 @@ export class JobCreateUi extends Component {
return;
}
// TODO: Show toast or inline error.
this.setState({
isValidatingIndexPattern: false,
});
// Expect an error in the shape provided by Angular's $http service.
if (error && error.data) {
const { error: errorString, statusCode } = error.data;
const indexPatternAsyncErrors = [(
<FormattedMessage
id="xpack.rollupJobs.create.errors.indexPatternValidationError"
defaultMessage="There was a problem validating this index pattern: {statusCode} {error}"
values={{ error: errorString, statusCode }}
/>
)];
this.setState({
indexPatternAsyncErrors,
indexPatternDateFields: [],
indexPatternTermsFields: [],
indexPatternHistogramFields: [],
indexPatternMetricsFields: [],
isValidatingIndexPattern: false,
});
return;
}
// This error isn't an HTTP error, so let the fatal error screen tell the user something
// unexpected happened.
fatalError(error, 'Rollup Job Wizard index pattern validation');
});
}, 300);