github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixing the title removal for gauges, metric, and markdown for Time Series Visual Builder (#10707)

Browse source 
* Fixing the title removal for gauges, metric, and markdown

* Adding comment about the $timeout
This commit is contained in:
Chris Cowan 2017-03-03 17:47:15 -07:00 • committed by GitHub
parent 46c9605e18
commit 053ebfa26c
1 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

36
src/core_plugins/metrics/public/directives/visualization.js
View file

@ -7,7 +7,7 @@ import addScope from '../lib/add_scope';
import modules from 'ui/modules';
import createBrushHandler from '../lib/create_brush_handler';
const app = modules.get('apps/metrics/directives');
app.directive('metricsVisualization', (timefilter) => {
app.directive('metricsVisualization', (timefilter, $timeout) => {
return {
restrict: 'E',
link: ($scope, $el, $attrs) => {
@ -19,22 +19,26 @@ app.directive('metricsVisualization', (timefilter) => {
// For Metrics, Gauges and markdown visualizations we want to hide the
// panel title because it just doens't make sense to show it.
const panel = $($el[0]).parents('.panel');
if (panel.length) {
const panelHeading = panel.find('.panel-heading');
const panelTitle = panel.find('.panel-title');
const matchingTypes = ['metric', 'gauge', 'markdown'];
if (panelHeading.length && panelTitle.length && _.contains(matchingTypes, $scope.model.type)) {
panel.css({ position: 'relative' });
panelHeading.css({
position: 'absolute',
top: 0,
right: 0,
zIndex: 100
});
panelTitle.css({ display: 'none' });
// This is wrapped in a timeout so it happens after the directive is mouted.
// otherwise the .panel might not be available.
$timeout(() => {
const panel = $($el[0]).parents('.panel');
if (panel.length) {
const panelHeading = panel.find('.panel-heading');
const panelTitle = panel.find('.panel-title');
const matchingTypes = ['metric', 'gauge', 'markdown'];
if (panelHeading.length && panelTitle.length && _.contains(matchingTypes, $scope.model.type)) {
panel.css({ position: 'relative' });
panelHeading.css({
position: 'absolute',
top: 0,
right: 0,
zIndex: 100
});
panelTitle.css({ display: 'none' });
}
}
}
}, 1);
}
};
});