github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] Fix entity controls update. (#55524)

Browse source 
Fixes an issue where the options in the internal state of the EntityControl component wouldn't update after a prop change. This had the effect that after a job change via the job selector, the entity control dropdown would stay empty.
This commit is contained in:
Walter Rafelsberger 2020-01-22 14:28:28 +01:00 • committed by GitHub
parent d47d20e758
commit 07d1dac0da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/legacy/plugins/ml/public/application/timeseriesexplorer/components/entity_control/entity_control.tsx
View file

@ -4,6 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/
import { isEqual } from 'lodash';
import React, { Component } from 'react';
import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
@ -47,8 +48,8 @@ export class EntityControl extends Component<EntityControlProps, EntityControlSt
};
componentDidUpdate(prevProps: EntityControlProps) {
const { entity, forceSelection, isLoading, options } = this.props;
const { selectedOptions } = this.state;
const { entity, forceSelection, isLoading, options: propOptions } = this.props;
const { options: stateOptions, selectedOptions } = this.state;
const { fieldValue } = entity;
@ -68,11 +69,16 @@ export class EntityControl extends Component<EntityControlProps, EntityControlSt
if (prevProps.isLoading === true && isLoading === false) {
this.setState({
isLoading: false,
options,
selectedOptions: selectedOptionsUpdate,
});
}
if (!isEqual(propOptions, stateOptions)) {
this.setState({
options: propOptions,
});
}
if (forceSelection && this.inputRef) {
this.inputRef.focus();
}

3
x-pack/legacy/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
View file

@ -94,6 +94,8 @@ function getEntityControlOptions(fieldValues) {
return [];
}
fieldValues.sort();
return fieldValues.map(value => {
return { label: value };
});
@ -163,7 +165,6 @@ export class TimeSeriesExplorer extends React.Component {
selectedDetectorIndex: PropTypes.number,
selectedEntities: PropTypes.object,
selectedForecastId: PropTypes.string,
setGlobalState: PropTypes.func.isRequired,
tableInterval: PropTypes.string,
tableSeverity: PropTypes.number,
zoom: PropTypes.object,