github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Synthetics] Fix performance breakdown link from error details page (#155393)

Browse source
This commit is contained in:
Shahzad 2023-04-20 18:23:36 +02:00 • committed by GitHub
parent 5120d692c8
commit 08a68dbe73
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 26 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
x-pack/plugins/synthetics/public/apps/synthetics/components/common/components/stderr_logs.tsx
View file

@ -53,6 +53,11 @@ export const StdErrorLogs = ({
sortable: true,
render: (date: string) => formatDate(date, 'dateTime'),
},
{
field: 'synthetics.type',
name: TYPE_LABEL,
sortable: true,
},
{
field: 'synthetics.payload.message',
name: 'Message',
@ -146,6 +151,10 @@ export const TIMESTAMP_LABEL = i18n.translate('xpack.synthetics.monitorList.time
defaultMessage: 'Timestamp',
});
export const TYPE_LABEL = i18n.translate('xpack.synthetics.monitorList.type', {
defaultMessage: 'Type',
});
export const ERROR_SUMMARY_LABEL = i18n.translate('xpack.synthetics.monitorList.errorSummary', {
defaultMessage: 'Error summary',
});

4
x-pack/plugins/synthetics/public/apps/synthetics/components/common/components/use_std_error_logs.ts
View file

@ -25,8 +25,8 @@ export const useStdErrorLogs = ({
bool: {
filter: [
{
term: {
'synthetics.type': 'stderr',
terms: {
'synthetics.type': ['stderr', 'stdout'],
},
},
...(monitorId

6
x-pack/plugins/synthetics/public/apps/synthetics/components/error_details/error_details_page.tsx
View file

@ -67,7 +67,11 @@ export function ErrorDetailsPage() {
/>
<EuiSpacer size="m" />
<EuiPanel hasShadow={false} hasBorder>
<TestRunErrorInfo journeyDetails={data?.details} showErrorTitle={false} />
<TestRunErrorInfo
journeyDetails={data?.details}
showErrorTitle={false}
showErrorLogs={true}
/>
</EuiPanel>
</EuiFlexItem>
<EuiFlexItem grow={1} style={{ height: 'fit-content' }}>

2
x-pack/plugins/synthetics/public/apps/synthetics/components/test_run_details/components/step_info.tsx
View file

@ -69,7 +69,7 @@ export const StepMetaInfo = ({
<EuiFlexItem grow={false}>
<StepDetailsLinkIcon
asButton
checkGroup={checkGroupId}
checkGroup={checkGroupId ?? step.monitor.check_group}
configId={monitorId}
stepIndex={stepIndex}
label={VIEW_PERFORMANCE}

17
x-pack/plugins/synthetics/public/apps/synthetics/components/test_run_details/components/test_run_error_info.tsx
View file

@ -18,9 +18,11 @@ export const TestRunErrorInfo = ({
journeyDetails,
hasNoSteps,
showErrorTitle = true,
showErrorLogs = false,
}: {
hasNoSteps?: boolean;
showErrorTitle?: boolean;
showErrorLogs?: boolean;
journeyDetails: SyntheticsJourneyApiResponse['details'];
}) => {
const isDownMonitor = journeyDetails?.journey?.monitor?.status === 'down';
@ -40,14 +42,13 @@ export const TestRunErrorInfo = ({
</EuiCallOut>
)}
<EuiSpacer size="m" />
{(hasNoSteps || isDownMonitor) &&
errorMessage?.includes('journey did not finish executing') && (
<StdErrorLogs
checkGroup={journeyDetails?.journey?.monitor.check_group}
hideTitle={false}
pageSize={10}
/>
)}
{isDownMonitor && (showErrorLogs || hasNoSteps) && (
<StdErrorLogs
checkGroup={journeyDetails?.journey?.monitor.check_group}
hideTitle={false}
pageSize={10}
/>
)}
</>
);
};