github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove kibana-design from the ultimate rule for scss files. (#157493)

Browse source 
## Summary

This was most likely a mistake during the migrating packages to jsonc,
`kibana-design` should be before the overrides so in PR's we would have
specific team members as reviewers. If none specified than
`kibana-design` would take over.

This is communicated with @elastic/kibana-design members.
This commit is contained in:
Efe Gürkan YALAMAN 2023-05-12 17:01:47 +02:00 • committed by GitHub
parent 612064aa8b
commit 08db7383cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
.github/CODEOWNERS vendored
View file

@ -1222,6 +1222,10 @@ x-pack/test/threat_intelligence_cypress @elastic/protections-experience
/x-pack/plugins/security_solution/public/common/components/guided_onboarding @elastic/security-threat-hunting-explore /x-pack/plugins/security_solution/public/common/components/guided_onboarding @elastic/security-threat-hunting-explore
/x-pack/plugins/security_solution/cypress/e2e/guided_onboarding @elastic/security-threat-hunting-explore /x-pack/plugins/security_solution/cypress/e2e/guided_onboarding @elastic/security-threat-hunting-explore
# Kibana design
# scss overrides should be below this line for specificity
**/*.scss @elastic/kibana-design
# Observability design # Observability design
/x-pack/plugins/apm/**/*.scss @elastic/observability-design /x-pack/plugins/apm/**/*.scss @elastic/observability-design
/x-pack/plugins/infra/**/*.scss @elastic/observability-design /x-pack/plugins/infra/**/*.scss @elastic/observability-design
@ -1251,12 +1255,3 @@ x-pack/plugins/translations/translations
#### ####
## These rules are always last so they take ultimate priority over everything else ## These rules are always last so they take ultimate priority over everything else
#### ####
# Design (at the bottom for specificity of SASS files)
**/*.scss @elastic/kibana-design
####
## These rules are always last so they take ultimate priority over everything else
####
**/*.scss @elastic/kibana-design

2
packages/kbn-generate/src/commands/codeowners_command.ts
View file

@ -37,8 +37,6 @@ const ULTIMATE_PRIORITY_RULES = `
#### ####
## These rules are always last so they take ultimate priority over everything else ## These rules are always last so they take ultimate priority over everything else
#### ####
**/*.scss @elastic/kibana-design
`; `;
export const CodeownersCommand: GenerateCommand = { export const CodeownersCommand: GenerateCommand = {