[8.x] [Security Solution][Notes] - limit visible text from note content on notes management page (#195296) (#195692)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Notes] - limit visible text from note content on
notes management page
(#195296)](https://github.com/elastic/kibana/pull/195296)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T23:49:36Z","message":"[Security
Solution][Notes] - limit visible text from note content on notes
management page
(#195296)","sha":"69ff471983a543c3052923e6b05385460079e45e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
limit visible text from note content on notes management
page","number":195296,"url":"https://github.com/elastic/kibana/pull/195296","mergeCommit":{"message":"[Security
Solution][Notes] - limit visible text from note content on notes
management page
(#195296)","sha":"69ff471983a543c3052923e6b05385460079e45e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195296","number":195296,"mergeCommit":{"message":"[Security
Solution][Notes] - limit visible text from note content on notes
management page
(#195296)","sha":"69ff471983a543c3052923e6b05385460079e45e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
This commit is contained in:
Kibana Machine 2024-10-10 12:36:40 +11:00 committed by GitHub
parent 695098b186
commit 090c150963
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 105 additions and 0 deletions

View file

@ -0,0 +1,28 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { render } from '@testing-library/react';
import React from 'react';
import { NoteContent } from './note_content';
import { NOTE_CONTENT_BUTTON_TEST_ID, NOTE_CONTENT_POPOVER_TEST_ID } from './test_ids';
const note = 'note-text';
describe('NoteContent', () => {
it('should render a note and the popover', () => {
const { getByTestId, getByText } = render(<NoteContent note={note} />);
const button = getByTestId(NOTE_CONTENT_BUTTON_TEST_ID);
expect(button).toBeInTheDocument();
expect(getByText(note)).toBeInTheDocument();
button.click();
expect(getByTestId(NOTE_CONTENT_POPOVER_TEST_ID)).toBeInTheDocument();
});
});

View file

@ -0,0 +1,73 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React, { memo, useCallback, useMemo, useState } from 'react';
import { EuiButtonEmpty, EuiMarkdownFormat, EuiPopover, useEuiTheme } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { css } from '@emotion/react';
import { NOTE_CONTENT_BUTTON_TEST_ID, NOTE_CONTENT_POPOVER_TEST_ID } from './test_ids';
const OPEN_POPOVER = i18n.translate('xpack.securitySolution.notes.expandRow.buttonLabel', {
defaultMessage: 'Expand',
});
export interface NoteContentProps {
/**
* The note content to display
*/
note: string;
}
/**
* Renders the note content to be displayed in the notes management table.
* The content is truncated with an expand button to show the full content within the row.
*/
export const NoteContent = memo(({ note }: NoteContentProps) => {
const { euiTheme } = useEuiTheme();
const [isPopoverOpen, setIsPopoverOpen] = useState(false);
const togglePopover = useCallback(() => setIsPopoverOpen((value) => !value), []);
const closePopover = useCallback(() => setIsPopoverOpen(false), []);
const button = useMemo(
() => (
<EuiButtonEmpty
title={OPEN_POPOVER}
aria-label={OPEN_POPOVER}
color="text"
flush="left"
onClick={togglePopover}
data-test-subj={NOTE_CONTENT_BUTTON_TEST_ID}
css={css`
height: ${euiTheme.size.l};
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
`}
>
{note}
</EuiButtonEmpty>
),
[euiTheme.size.l, note, togglePopover]
);
return (
<EuiPopover
button={button}
isOpen={isPopoverOpen}
closePopover={closePopover}
panelStyle={{ maxWidth: '50%', maxHeight: '50%', overflow: 'auto' }}
>
<EuiMarkdownFormat textSize="s" data-test-subj={NOTE_CONTENT_POPOVER_TEST_ID}>
{note}
</EuiMarkdownFormat>
</EuiPopover>
);
});
NoteContent.displayName = 'NoteContent';

View file

@ -17,3 +17,5 @@ export const DELETE_NOTE_BUTTON_TEST_ID = `${PREFIX}DeleteNotesButton` as const;
export const OPEN_TIMELINE_BUTTON_TEST_ID = `${PREFIX}OpenTimelineButton` as const;
export const OPEN_FLYOUT_BUTTON_TEST_ID = `${PREFIX}OpenFlyoutButton` as const;
export const TIMELINE_DESCRIPTION_COMMENT_TEST_ID = `${PREFIX}TimelineDescriptionComment` as const;
export const NOTE_CONTENT_BUTTON_TEST_ID = `${PREFIX}NoteContentButton` as const;
export const NOTE_CONTENT_POPOVER_TEST_ID = `${PREFIX}NoteContentPopover` as const;

View file

@ -44,6 +44,7 @@ import { DeleteConfirmModal } from '../components/delete_confirm_modal';
import * as i18n from './translations';
import { OpenFlyoutButtonIcon } from '../components/open_flyout_button';
import { OpenTimelineButtonIcon } from '../components/open_timeline_button';
import { NoteContent } from '../components/note_content';
const columns: Array<EuiBasicTableColumn<Note>> = [
{
@ -94,6 +95,7 @@ const columns: Array<EuiBasicTableColumn<Note>> = [
{
field: 'note',
name: i18n.NOTE_CONTENT_COLUMN,
render: (note: Note['note']) => <>{note && <NoteContent note={note} />}</>,
},
{
field: 'created',