[8.18] [Lens] Fix getIndexPatternsObjects for index-pattern only and minor cleanups (#215325) (#217564)

# Backport This will backport the following commits from `main` to `8.18`: - [[Lens] Fix getIndexPatternsObjects for index-pattern only and minor cleanups (#215325)](https://github.com/elastic/kibana/pull/215325)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
2025-04-24 09:48:58 -04:00 · 2025-04-08 20:23:29 +02:00 · 2025-04-08 20:23:29 +02:00 · 09d4d4f3f6
commit 09d4d4f3f6
parent bc5ae4568d
7 changed files with 29 additions and 24 deletions
--- a/src/platform/plugins/shared/share/common/url_service/locators/README.md
+++ b/src/platform/plugins/shared/share/common/url_service/locators/README.md
@ -8,7 +8,7 @@ so the developer of the app/page has a way to change their url structure without
 breaking users of this system. If users were to generate the URLs on their own, 
 using string concatenation, those links may break often.

-Owners: __Kibana App Services team__.
+Owners: __@elastic/appex-sharedux__.


 ## Producer Usage
--- a/x-pack/platform/plugins/shared/lens/common/locator/locator.ts
+++ b/x-pack/platform/plugins/shared/lens/common/locator/locator.ts
@ -162,12 +162,12 @@ function getStateFromParams(params: LensAppLocatorParams): MainHistoryLocationSt
    return {};
  }
  const outputState: LensShareableState = {
-    activeDatasourceId: params.activeDatasourceId!,
-    visualization: params.visualization!,
+    activeDatasourceId: params.activeDatasourceId,
+    visualization: params.visualization,
    datasourceStates: Object.fromEntries(
-      Object.entries(params.datasourceStates!).map(([id, { state }]) => [id, state])
+      Object.entries(params.datasourceStates).map(([id, { state }]) => [id, state])
    ) as Record<string, { state: unknown }> & SerializableRecord,
-    references: params.references!,
+    references: params.references,
  };
  if (params.dataViewSpecs) {
    outputState.dataViewSpecs = params.dataViewSpecs;
--- a/x-pack/platform/plugins/shared/lens/public/lens_attribute_service.ts
+++ b/x-pack/platform/plugins/shared/lens/public/lens_attribute_service.ts
@ -6,7 +6,7 @@
 */

 import type { CoreStart } from '@kbn/core/public';
-import type { SavedObjectReference } from '@kbn/core/types';
+import type { SavedObjectReference } from '@kbn/core/server';
 import { OnSaveProps } from '@kbn/saved-objects-plugin/public';
 import { SavedObjectCommon } from '@kbn/saved-objects-finder-plugin/common';
 import { noop } from 'lodash';
--- a/x-pack/platform/plugins/shared/lens/public/persistence/saved_object_store.ts
+++ b/x-pack/platform/plugins/shared/lens/public/persistence/saved_object_store.ts
@ -6,7 +6,7 @@
 */

 import type { AggregateQuery, Filter, Query } from '@kbn/es-query';
-import type { SavedObjectReference } from '@kbn/core/public';
+import type { SavedObjectReference } from '@kbn/core/server';
 import type { DataViewSpec } from '@kbn/data-views-plugin/public';
 import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';
 import type { SearchQuery } from '@kbn/content-management-plugin/common';
--- a/x-pack/platform/plugins/shared/lens/public/react_embeddable/expressions/update_data_views.ts
+++ b/x-pack/platform/plugins/shared/lens/public/react_embeddable/expressions/update_data_views.ts
@ -15,8 +15,13 @@ export async function getUsedDataViews(
  dataViews: LensEmbeddableStartServices['dataViews']
 ) {
  const [{ indexPatterns }, ...adHocDataViews] = await Promise.all([
-    getIndexPatternsObjects(references.map(({ id }) => id) || [], dataViews),
-    ...Object.values(adHocDataViewsSpecs || {}).map((spec) => dataViews.create(spec)),
+    getIndexPatternsObjects(
+      // get index pattern only references
+      references.filter(({ type }) => type === 'index-pattern').map(({ id }) => id),
+      dataViews
+    ),
+
+    ...Object.values(adHocDataViewsSpecs ?? {}).map((spec) => dataViews.create(spec)),
  ]);

  return uniqBy(indexPatterns.concat(adHocDataViews), 'id');
--- a/x-pack/platform/plugins/shared/lens/public/state_management/lens_slice.ts
+++ b/x-pack/platform/plugins/shared/lens/public/state_management/lens_slice.ts
@ -118,25 +118,25 @@ export const getPreloadedState = ({
  const state: LensAppState = {
    ...initialState,
    isLoading: true,
+    query,
    // Do not use app-specific filters from previous app,
    // only if Lens was opened with the intention to visualize a field (e.g. coming from Discover)
-    query: query as Query,
    filters: !initialContext
      ? data.query.filterManager.getGlobalFilters()
      : 'searchFilters' in initialContext && initialContext.searchFilters
      ? initialContext.searchFilters
      : data.query.filterManager.getFilters(),
-    searchSessionId: data.search.session.getSessionId() || '',
+    searchSessionId: data.search.session.getSessionId() ?? '',
    resolvedDateRange: getResolvedDateRange(data.query.timefilter.timefilter),
    isLinkedToOriginatingApp: Boolean(
-      embeddableEditorIncomingState?.originatingApp ||
-        (initialContext && 'isEmbeddable' in initialContext && initialContext?.isEmbeddable)
+      embeddableEditorIncomingState?.originatingApp ??
+        (initialContext && 'isEmbeddable' in initialContext && initialContext.isEmbeddable)
    ),
    activeDatasourceId: initialDatasourceId,
    datasourceStates,
    visualization: {
      state: null,
-      activeId: Object.keys(visualizationMap)[0] || null,
+      activeId: Object.keys(visualizationMap)[0] ?? null,
    },
  };
  return state;
--- a/x-pack/platform/plugins/shared/lens/public/utils.ts
+++ b/x-pack/platform/plugins/shared/lens/public/utils.ts
@ -48,7 +48,7 @@ export function getVisualizeGeoFieldMessage(fieldType: string) {
  });
 }

-export const isLensRange = (range: unknown = {}): range is RangeTypeLens => {
+export function isLensRange(range: unknown = {}): range is RangeTypeLens {
  if (!range || typeof range !== 'object') return false;
  const { from, to, label } = range as RangeTypeLens;

@ -57,23 +57,23 @@ export const isLensRange = (range: unknown = {}): range is RangeTypeLens => {
    (typeof from === 'number' || from === null) &&
    (typeof to === 'number' || to === null)
  );
-};
+}

-export const getResolvedDateRange = function (timefilter: TimefilterContract) {
+export function getResolvedDateRange(timefilter: TimefilterContract) {
  const { from, to } = timefilter.getTime();
  return { fromDate: from, toDate: to };
-};
+}

-export const getAbsoluteDateRange = function (timefilter: TimefilterContract) {
+export function getAbsoluteDateRange(timefilter: TimefilterContract) {
  const { from, to } = timefilter.getTime();
  const { min, max } = timefilter.calculateBounds({
    from,
    to,
  });
  return { fromDate: min?.toISOString() || from, toDate: max?.toISOString() || to };
-};
+}

-export const convertToAbsoluteDateRange = function (dateRange: DateRange, now: Date) {
+export function convertToAbsoluteDateRange(dateRange: DateRange, now: Date) {
  const absRange = getAbsoluteTimeRange(
    {
      from: dateRange.fromDate as string,
@ -86,7 +86,7 @@ export const convertToAbsoluteDateRange = function (dateRange: DateRange, now: D
    fromDate: absRange.from,
    toDate: absRange.to,
  };
-};
+}

 export function containsDynamicMath(dateMathString: string) {
  return dateMathString.includes('now');
@ -116,9 +116,9 @@ export function getActiveVisualizationIdFromDoc(doc?: LensDocument) {
  return doc.visualizationType || null;
 }

-export const getInitialDatasourceId = (datasourceMap: DatasourceMap, doc?: LensDocument) => {
+export function getInitialDatasourceId(datasourceMap: DatasourceMap, doc?: LensDocument) {
  return (doc && getActiveDatasourceIdFromDoc(doc)) || Object.keys(datasourceMap)[0] || null;
-};
+}

 export function getInitialDataViewsObject(
  indexPatterns: IndexPatternMap,