github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

allow visualizations to have full width editor (#10192)

Browse source 
Backports PR #10175

**Commit 1:**
allow visualizations to hide sidebar editor

* Original sha: ebd3926f93
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T09:51:12Z

**Commit 2:**
fixing styles

* Original sha: 10d6cff9c9
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T14:37:54Z

**Commit 3:**
fixing broken html

* Original sha: 7a6aa89699
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T15:00:45Z
This commit is contained in:
jasper 2017-02-06 04:25:29 -05:00 • committed by Peter Pisljar
parent 932b787912
commit 09d644b567
3 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/core_plugins/kibana/public/visualize/editor/editor.html
View file

@ -73,11 +73,14 @@
<div class="vis-editor-content">
<div class="collapsible-sidebar" ng-if="chrome.getVisible()">
<vis-editor-sidebar class="vis-editor-sidebar"></vis-editor-sidebar>
<vis-editor-vis-options ng-if="vis.type.fullEditor" vis="vis" saved-vis="savedVis" ui-state="uiState"
class="vis-editor-full-options"></vis-editor-vis-options>
<div class="collapsible-sidebar" ng-if="!vis.type.fullEditor && chrome.getVisible()" >
<vis-editor-sidebar class="vis-editor-sidebar"></vis-editor-sidebar>
</div>
<div class="vis-editor-canvas" ng-class="{ embedded: !chrome.getVisible() }">
<div class="vis-editor-canvas" ng-if="!vis.type.fullEditor" ng-class="{ embedded: !chrome.getVisible() }">
<visualize
vis="vis"
render-counter
@ -87,5 +90,6 @@
search-source="savedVis.searchSource">
</visualize>
</div>
</div>
</visualize-app>

7
src/core_plugins/kibana/public/visualize/editor/styles/_editor.less
View file

@ -128,6 +128,13 @@
}
}
.vis-editor-full-options .visualization-options {
display: flex;
flex-direction: column;
flex: 1 0 auto;
padding: 0px;
}
.vis-editor-agg {
.flex-parent();

1
src/ui/public/vis/vis_type.js
View file

@ -15,6 +15,7 @@ export default function VisTypeFactory(Private) {
this.schemas = opts.schemas || new VisTypeSchemas();
this.params = opts.params || {};
this.requiresSearch = opts.requiresSearch == null ? true : opts.requiresSearch; // Default to true unless otherwise specified
this.fullEditor = opts.fullEditor == null ? false : opts.fullEditor;
this.implementsRenderComplete = opts.implementsRenderComplete || false;
}