github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

refact(NA): remove set loop from upgrade assistant usage collector (#63977) (#64197)

Browse source 
* refact(NA): use default telemetry obj in the set loop

* chore(NA): fix typecheck

* fix(NA): test run with lodash has

* chore(NA): fix older lodash has

* chore(NA): remove lodash has usage
This commit is contained in:
Tiago Costa 2020-04-22 16:57:56 +01:00 • committed by GitHub
parent da906e7e25
commit 0aea444da8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.test.ts
View file

@ -38,6 +38,7 @@ describe('Upgrade Assistant Usage Collector', () => {
'ui_reindex.open': 4,
'ui_reindex.start': 2,
'ui_reindex.stop': 1,
'ui_reindex.not_defined': 1,
},
};
},

25
x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts
View file

@ -4,7 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/
import { set } from 'lodash';
import { get } from 'lodash';
import { SavedObjectsRepository } from 'src/server/saved_objects/service/lib/repository';
import {
UPGRADE_ASSISTANT_DOC_ID,
@ -74,16 +74,19 @@ export async function fetchUpgradeAssistantMetrics(
return defaultTelemetrySavedObject;
}
const upgradeAssistantTelemetrySOAttrsKeys = Object.keys(
upgradeAssistantTelemetrySavedObjectAttrs
);
const telemetryObj = defaultTelemetrySavedObject;
upgradeAssistantTelemetrySOAttrsKeys.forEach((key: string) => {
set(telemetryObj, key, upgradeAssistantTelemetrySavedObjectAttrs[key]);
});
return telemetryObj as UpgradeAssistantTelemetrySavedObject;
return {
ui_open: {
overview: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_open.overview', 0),
cluster: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_open.cluster', 0),
indices: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_open.indices', 0),
},
ui_reindex: {
close: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.close', 0),
open: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.open', 0),
start: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.start', 0),
stop: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.stop', 0),
},
} as UpgradeAssistantTelemetrySavedObject;
};
return {