github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[9.0] [Dataset Quality] Wrap Discover data view checks in retries (#214172) (#214351)

Browse source 
# Backport

This will backport the following commits from `main` to `9.0`:
- [[Dataset Quality] Wrap Discover data view checks in retries
(#214172)](https://github.com/elastic/kibana/pull/214172)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Felix
Stürmer","email":"weltenwort@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-13T11:29:44Z","message":"[Dataset
Quality] Wrap Discover data view checks in retries (#214172)\n\n##
📝 Summary\n\nThis wraps the checks for the correct data view after
navigation to\nDiscover into retries in the dataset quality functional
tests, because\nthese checks recently failed because loading was not yet
finished.\n\n🏁 closes https://github.com/elastic/kibana/issues/213751\n🏁
closes https://github.com/elastic/kibana/issues/214029\n🏁 closes
https://github.com/elastic/kibana/issues/214183","sha":"535b01527133fa8e575b25be91dd21c718334e8a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:obs-ux-logs","v9.1.0"],"title":"[Dataset
Quality] Wrap Discover data view checks in
retries","number":214172,"url":"https://github.com/elastic/kibana/pull/214172","mergeCommit":{"message":"[Dataset
Quality] Wrap Discover data view checks in retries (#214172)\n\n##
📝 Summary\n\nThis wraps the checks for the correct data view after
navigation to\nDiscover into retries in the dataset quality functional
tests, because\nthese checks recently failed because loading was not yet
finished.\n\n🏁 closes https://github.com/elastic/kibana/issues/213751\n🏁
closes https://github.com/elastic/kibana/issues/214029\n🏁 closes
https://github.com/elastic/kibana/issues/214183","sha":"535b01527133fa8e575b25be91dd21c718334e8a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214172","number":214172,"mergeCommit":{"message":"[Dataset
Quality] Wrap Discover data view checks in retries (#214172)\n\n##
📝 Summary\n\nThis wraps the checks for the correct data view after
navigation to\nDiscover into retries in the dataset quality functional
tests, because\nthese checks recently failed because loading was not yet
finished.\n\n🏁 closes https://github.com/elastic/kibana/issues/213751\n🏁
closes https://github.com/elastic/kibana/issues/214029\n🏁 closes
https://github.com/elastic/kibana/issues/214183","sha":"535b01527133fa8e575b25be91dd21c718334e8a"}}]}]
BACKPORT-->

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2025-03-14 00:29:11 +11:00 • committed by GitHub
parent aec38fb77c
commit 0bf792894a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/test/functional/apps/dataset_quality/dataset_quality_details.ts
View file

@ -329,8 +329,10 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
await discoverButton.click();
// Confirm dataset selector text in observability logs explorer
const datasetSelectorText = await PageObjects.discover.getCurrentDataViewId();
originalExpect(datasetSelectorText).toMatch(regularDatasetName);
await retry.try(async () => {
const datasetSelectorText = await PageObjects.discover.getCurrentDataViewId();
originalExpect(datasetSelectorText).toMatch(regularDatasetName);
});
});
it('should go discover for degraded docs when the button next to breakdown selector is clicked', async () => {
@ -343,8 +345,10 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
);
// Confirm dataset selector text in observability logs explorer
const datasetSelectorText = await PageObjects.discover.getCurrentDataViewId();
originalExpect(datasetSelectorText).toMatch(apacheAccessDatasetName);
await retry.try(async () => {
const datasetSelectorText = await PageObjects.discover.getCurrentDataViewId();
originalExpect(datasetSelectorText).toMatch(apacheAccessDatasetName);
});
});
});

8
x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table.ts
View file

@ -26,6 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'svlCommonNavigation',
'svlCommonPage',
]);
const retry = getService('retry');
const synthtrace = getService('svlLogsSynthtraceClient');
const to = '2024-01-01T12:00:00.000Z';
const apacheAccessDatasetName = 'apache.access';
@ -144,9 +145,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await (await actionsCol.getCellChildren('a'))[rowIndexToOpen].click(); // Click "Open"
// Confirm dataset selector text in observability logs explorer
const datasetSelectorText = await PageObjects.discover.getCurrentDataViewId();
originalExpect(datasetSelectorText).toMatch(datasetName);
await retry.try(async () => {
const datasetSelectorText = await PageObjects.discover.getCurrentDataViewId();
originalExpect(datasetSelectorText).toMatch(datasetName);
});
// Return to Dataset Quality Page
await PageObjects.datasetQuality.navigateTo();