mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
# Backport This will backport the following commits from `main` to `8.x`: - [Alerts table in Rule Preview panel fills container width (#214028)](https://github.com/elastic/kibana/pull/214028) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-03-12T19:21:33Z","message":"Alerts table in Rule Preview panel fills container width (#214028)\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/213706.\n\nI suspect that this stopped working when #206523 removed the\n`FullScreenContainer` from the inner StatefulEventsViewer component;\nthat change combined with the `display:flex` on this parent element\ncaused the table to no longer grow as expected.\n\nLuckily, the fix here was simply not using flexbox on the container.\nSince the table is the only element within this container, I saw no\nreason why flexbox was needed here; testing has confirmed this.\n\n### Screenshot (after fix; see bug for \"before\" image)\n<kbd><img width=\"1709\" alt=\"Screenshot 2025-03-11 at 5 35 43 PM\"\nsrc=\"https://github.com/user-attachments/assets/108be815-00e2-48b7-8821-e63566eefa09\"\n/></kbd>","sha":"01e31ea5f25fe1ca4d8ee30369ba5465f3041498","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Feature:Detection Rule Preview","backport:prev-minor","backport:prev-major","Team:Detection Engine","v8.18.0","v9.1.0"],"title":"Alerts table in Rule Preview panel fills container width","number":214028,"url":"https://github.com/elastic/kibana/pull/214028","mergeCommit":{"message":"Alerts table in Rule Preview panel fills container width (#214028)\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/213706.\n\nI suspect that this stopped working when #206523 removed the\n`FullScreenContainer` from the inner StatefulEventsViewer component;\nthat change combined with the `display:flex` on this parent element\ncaused the table to no longer grow as expected.\n\nLuckily, the fix here was simply not using flexbox on the container.\nSince the table is the only element within this container, I saw no\nreason why flexbox was needed here; testing has confirmed this.\n\n### Screenshot (after fix; see bug for \"before\" image)\n<kbd><img width=\"1709\" alt=\"Screenshot 2025-03-11 at 5 35 43 PM\"\nsrc=\"https://github.com/user-attachments/assets/108be815-00e2-48b7-8821-e63566eefa09\"\n/></kbd>","sha":"01e31ea5f25fe1ca4d8ee30369ba5465f3041498"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214028","number":214028,"mergeCommit":{"message":"Alerts table in Rule Preview panel fills container width (#214028)\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/213706.\n\nI suspect that this stopped working when #206523 removed the\n`FullScreenContainer` from the inner StatefulEventsViewer component;\nthat change combined with the `display:flex` on this parent element\ncaused the table to no longer grow as expected.\n\nLuckily, the fix here was simply not using flexbox on the container.\nSince the table is the only element within this container, I saw no\nreason why flexbox was needed here; testing has confirmed this.\n\n### Screenshot (after fix; see bug for \"before\" image)\n<kbd><img width=\"1709\" alt=\"Screenshot 2025-03-11 at 5 35 43 PM\"\nsrc=\"https://github.com/user-attachments/assets/108be815-00e2-48b7-8821-e63566eefa09\"\n/></kbd>","sha":"01e31ea5f25fe1ca4d8ee30369ba5465f3041498"}}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
This commit is contained in:
parent
5532859af3
commit
0d93b158a7
1 changed files with 0 additions and 2 deletions
|
@ -38,8 +38,6 @@ import { INSPECT_ACTION } from '../../../../common/components/visualization_acti
|
|||
|
||||
const FullScreenContainer = styled.div<{ $isFullScreen: boolean }>`
|
||||
height: ${({ $isFullScreen }) => ($isFullScreen ? '100%' : undefined)};
|
||||
flex: 1 1 auto;
|
||||
display: flex;
|
||||
width: 100%;
|
||||
`;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue