Adding data- prefix before attributes, began writing tests

Adding shared-item title tests

Switching up the panel tests

Adding description tests

Fixing linting

Adding dashboard timefilter test

Adding visualization shared-item tests

Adding shared-timefilter tests

Adding discover shared-item tests

src/core_plugins/kibana/public/dashboard/panel/panel.html

@@ -32,8 +32,8 @@
     show-spy-panel="!isFullScreenMode"
     ui-state="uiState"
     shared-item
-    title="{{savedObj.title}}"
-    description="{{savedObj.description}}"
+    data-title="{{savedObj.title}}"
+    data-description="{{savedObj.description}}"
     render-counter
     class="panel-content">
   </visualize>
@@ -44,8 +44,8 @@
     sorting="panel.sort"
     columns="panel.columns"
     shared-item
-    title="{{savedObj.title}}"
-    description="{{savedObj.description}}"
+    data-title="{{savedObj.title}}"
+    data-description="{{savedObj.description}}"
     render-counter
     class="panel-content"
     filter="filter">

src/core_plugins/kibana/public/discover/index.html

@@ -127,8 +127,8 @@
                 infinite-scroll="true"
                 filter="filterQuery"
                 shared-item
-                title="{{opts.savedSearch.lastSavedTitle}}"
-                description="{{opts.savedSearch.description}}"
+                data-title="{{opts.savedSearch.lastSavedTitle}}"
+                data-description="{{opts.savedSearch.description}}"
                 render-counter>
               </doc-table>
 

src/core_plugins/kibana/public/visualize/editor/editor.html

@@ -82,8 +82,8 @@
       <visualize
         vis="vis"
         shared-item
-        title="{{savedVis.lastSavedTitle}}"
-        description="{{savedVis.description}}"
+        data-title="{{savedVis.lastSavedTitle}}"
+        data-description="{{savedVis.description}}"
         render-counter
         ui-state="uiState"
         show-spy-panel="chrome.getVisible()"

src/ui/public/timepicker/__tests__/toggle.js

@@ -5,15 +5,17 @@ import $ from 'jquery';
 
 describe('kbnGlobalTimepicker', function () {
   let compile;
+  let scope;
 
   beforeEach(() => {
     ngMock.module('kibana');
     ngMock.inject(($compile, $rootScope) => {
+      scope = $rootScope.$new();
       compile = () => {
         const $el = $('<kbn-global-timepicker></kbn-global-timepicker>');
         $el.data('$kbnTopNavController', {}); // Mock the kbnTopNav
-        $rootScope.$apply();
-        $compile($el)($rootScope);
+        $compile($el)(scope);
+        scope.$apply();
         return $el;
       };
     });
@@ -22,4 +24,18 @@ describe('kbnGlobalTimepicker', function () {
     const $el = compile();
     expect($el.attr('data-test-subj')).to.be('globalTimepicker');
   });
+  it('sets shared-timefilter to false when timefilter.enabled is false', function () {
+    scope.timefilter = {
+      enabled: false
+    };
+    const $el = compile();
+    expect($el.attr('shared-timefilter')).to.eql('false');
+  });
+  it('sets shared-timefilter to true when timefilter.enabled is true', function () {
+    scope.timefilter = {
+      enabled: true
+    };
+    const $el = compile();
+    expect($el.attr('shared-timefilter')).to.eql('true');
+  });
 });

test/fixtures/dump_data/discover.mapping.json

@@ -0,0 +1 @@
+{".kibana":{"mappings":{"index-pattern":{"properties":{"fields":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}},"timeFieldName":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}},"title":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}},"sourceFilters":{"type":"text","fields":{"keyword":{"type":"keyword","ignore_above":256}}}}}}}}

test/functional/apps/dashboard/_dashboard.js

@@ -78,7 +78,7 @@ bdd.describe('dashboard tab', function describeIndexTests() {
       { dataCol: '1', dataRow: (height * 3) + 1, dataSizeX: width, dataSizeY: height, title: titles[6] }
     ];
     return PageObjects.common.tryForTime(10000, function () {
-      return PageObjects.dashboard.getPanelData()
+      return PageObjects.dashboard.getPanelSizeData()
         .then(function (panelTitles) {
           PageObjects.common.log('visualization titles = ' + panelTitles);
           PageObjects.common.saveScreenshot('Dashboard-visualization-sizes');
@@ -87,6 +87,7 @@ bdd.describe('dashboard tab', function describeIndexTests() {
     });
   });
 
+
   bdd.it('filters when a pie chart slice is clicked', async function () {
     let descriptions = await PageObjects.dashboard.getFilterDescriptions(1000);
     expect(descriptions.length).to.equal(0);
@@ -103,4 +104,24 @@ bdd.describe('dashboard tab', function describeIndexTests() {
     const isDarkThemeOn = await PageObjects.dashboard.isDarkThemeOn();
     expect(isDarkThemeOn).to.equal(true);
   });
+
+  bdd.it('should have shared-items-count set to the number of visualizations', function  checkSavedItemsCount() {
+    const visualizations = PageObjects.dashboard.getTestVisualizations();
+    return PageObjects.common.tryForTime(10000, () => PageObjects.dashboard.getSharedItemsCount())
+      .then(function (count) {
+        PageObjects.common.log('shared-items-count = ' + count);
+        expect(count).to.eql(visualizations.length);
+      });
+  });
+
+  bdd.it('should have panels with expected shared-item title and description', function checkTitles() {
+    const visualizations = PageObjects.dashboard.getTestVisualizations();
+    return PageObjects.common.tryForTime(10000, function () {
+      return PageObjects.dashboard.getPanelSharedItemData()
+        .then(function (data) {
+          expect(data.map(item => item.title)).to.eql(visualizations.map(v => v.name));
+          expect(data.map(item => item.description)).to.eql(visualizations.map(v => v.description));
+        });
+    });
+  });
 });

test/functional/apps/discover/_discover.js

@@ -20,7 +20,7 @@ bdd.describe('discover app', function describeIndexTests() {
     // delete .kibana index and update configDoc
     await esClient.deleteAndUpdateConfigDoc({ 'dateFormat:tz':'UTC', 'defaultIndex':'logstash-*' });
     PageObjects.common.debug('load kibana index with default index pattern');
-    await elasticDump.elasticLoad('visualize','.kibana');
+    await elasticDump.elasticLoad('discover','.kibana');
 
     // and load a set of makelogs data
     await scenarioManager.loadIfEmpty('logstashFunctional');
@@ -32,6 +32,7 @@ bdd.describe('discover app', function describeIndexTests() {
 
   bdd.describe('query', function () {
     const queryName1 = 'Query # 1';
+    const queryDescription1 = 'Query # 1 Description';
 
     bdd.it('should show correct time range string by timepicker', async function () {
       const actualTimeString = await PageObjects.discover.getTimespanText();
@@ -226,4 +227,19 @@ bdd.describe('discover app', function describeIndexTests() {
       expect(await PageObjects.header.isTimepickerOpen()).to.be(false);
     });
   });
+
+
+  bdd.describe('shared-item', function () {
+    bdd.it('should have correct shared-item title and description', async () => {
+      const expected = {
+        title: 'A Saved Search',
+        description: 'A Saved Search Description'
+      };
+
+      await PageObjects.discover.loadSavedSearch(expected.title);
+      const { title, description } = await PageObjects.common.getSharedItemTitleAndDescription();
+      expect(title).to.eql(expected.title);
+      expect(description).to.eql(expected.description);
+    });
+  });
 });

test/functional/apps/visualize/_shared_item.js

@@ -0,0 +1,31 @@
+import expect from 'expect.js';
+
+import {
+  bdd
+} from '../../../support';
+
+import PageObjects from '../../../support/page_objects';
+
+bdd.describe('visualize app', function describeIndexTests() {
+
+  bdd.before(function () {
+    PageObjects.common.debug('navigateToApp visualize');
+    return PageObjects.common.navigateToApp('visualize');
+  });
+
+  bdd.describe('shared-item', function indexPatternCreation() {
+
+    bdd.it('should have the correct shared-item title and description', function () {
+      const expected = {
+        title: 'Visualization AreaChart',
+        description: 'AreaChart'
+      };
+      return PageObjects.visualize.clickVisualizationByName('Visualization AreaChart')
+        .then(() => PageObjects.common.getSharedItemTitleAndDescription())
+        .then(({ title, description }) => {
+          expect(title).to.eql(expected.title);
+          expect(description).to.eql(expected.description);
+        });
+    });
+  });
+});

test/functional/apps/visualize/index.js

@@ -42,4 +42,5 @@ bdd.describe('visualize app', function () {
   require('./_vertical_bar_chart');
   require('./_heatmap_chart');
   require('./_point_series_options');
+  require('./_shared_item');
 });

test/support/page_objects/common.js

@@ -330,4 +330,15 @@ export default class Common {
     this.debug(`Found ${elements.length} for selector ${selector}`);
     return elements;
   }
+
+  async getSharedItemTitleAndDescription() {
+    const element = await this.remote
+    .setFindTimeout(defaultFindTimeout)
+    .findByCssSelector('[shared-item]');
+
+    return {
+      title: await element.getAttribute('data-title'),
+      description: await element.getAttribute('data-description')
+    };
+  }
 }

test/support/page_objects/dashboard_page.js

@@ -94,7 +94,7 @@ export default class DashboardPage {
 
   clickVizNameLink(vizName) {
     return this.findTimeout
-    .findByLinkText(vizName)
+    .findByPartialLinkText(vizName)
     .click();
   }
 
@@ -200,8 +200,8 @@ export default class DashboardPage {
     });
   }
 
-  getPanelData() {
-    PageObjects.common.debug('in getPanelData');
+  getPanelSizeData() {
+    PageObjects.common.debug('in getPanelSizeData');
     return this.findTimeout
     .findAllByCssSelector('li.gs-w')
     .then(function (titleObjects) {
@@ -251,18 +251,22 @@ export default class DashboardPage {
     });
   }
 
-  getTestVisualizationNames() {
+  getTestVisualizations() {
     return [
-      'Visualization PieChart',
-      'Visualization☺ VerticalBarChart',
-      'Visualization漢字 AreaChart',
-      'Visualization☺漢字 DataTable',
-      'Visualization漢字 LineChart',
-      'Visualization TileMap',
-      'Visualization MetricChart'
+      { name: 'Visualization PieChart', description: 'PieChart' },
+      { name: 'Visualization☺ VerticalBarChart', description: 'VerticalBarChart' },
+      { name: 'Visualization漢字 AreaChart', description: 'AreaChart' },
+      { name: 'Visualization☺漢字 DataTable', description: 'DataTable' },
+      { name: 'Visualization漢字 LineChart', description: 'LineChart' },
+      { name: 'Visualization TileMap', description: 'TileMap' },
+      { name: 'Visualization MetricChart', description: 'MetricChart' }
     ];
   }
 
+  getTestVisualizationNames() {
+    return this.getTestVisualizations().map(visualization => visualization.name);
+  }
+
   addVisualizations(visualizations) {
     return visualizations.reduce(function (promise, vizName) {
       return promise
@@ -301,4 +305,33 @@ export default class DashboardPage {
     return slices[0].click();
   }
 
+  getSharedItemsCount() {
+    PageObjects.common.debug('in getSharedItemsCount');
+    const attributeName = 'shared-items-count';
+    return this.findTimeout
+    .findByCssSelector(`[${attributeName}]`)
+    .then(function (element) {
+      if (element) {
+        return element.getAttribute(attributeName);
+      }
+
+      return Promise.reject();
+    });
+  }
+
+  getPanelSharedItemData() {
+    PageObjects.common.debug('in getPanelSharedItemData');
+    return this.findTimeout
+    .findAllByCssSelector('li.gs-w')
+    .then(function (elements) {
+      return Promise.all(elements.map(async element => {
+        const sharedItem = await element.findByCssSelector('[shared-item]');
+        return {
+          title: await sharedItem.getAttribute('data-title'),
+          description: await sharedItem.getAttribute('data-description')
+        };
+      }));
+    });
+  }
+
 }

test/support/page_objects/discover_page.js

@@ -49,7 +49,7 @@ export default class DiscoverPage {
   loadSavedSearch(searchName) {
     return this.clickLoadSavedSearchButton()
     .then(() => {
-      this.findTimeout.findByLinkText(searchName).click();
+      this.findTimeout.findByPartialLinkText(searchName).click();
     })
     .then(() => {
       return PageObjects.header.waitUntilLoadingHasFinished();

test/support/page_objects/header_page.js

@@ -186,4 +186,12 @@ export default class HeaderPage {
   async getPrettyDuration() {
     return await PageObjects.common.findTestSubject('globalTimepickerRange').getVisibleText();
   }
+
+  async isSharedTimefilterEnabled() {
+    const element = await this.remote
+    .setFindTimeout(defaultFindTimeout)
+    .findByCssSelector(`[shared-timefilter=true]`);
+
+    return new Boolean(element);
+  }
 }

test/support/page_objects/visualize_page.js

@@ -359,14 +359,14 @@ export default class VisualizePage {
       .type(vizName.replace('-',' '));
   }
 
-  clickVisualizationByLinkText(vizName) {
+  clickVisualizationByName(vizName) {
     const self = this;
     PageObjects.common.debug('clickVisualizationByLinkText(' + vizName + ')');
 
     return PageObjects.common.try(function tryingForTime() {
       return self.remote
       .setFindTimeout(defaultFindTimeout)
-      .findByLinkText(vizName)
+      .findByPartialLinkText(vizName)
       .click();
     });
   }
@@ -382,7 +382,7 @@ export default class VisualizePage {
   }
 
   openSavedVisualization(vizName) {
-    return this.clickVisualizationByLinkText(vizName);
+    return this.clickVisualizationByName(vizName);
   }
 
   getXAxisLabels() {