github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[7.3] Restore discover histogram selection triggering fetch (#43097) (#43287)

Browse source 
* Restore discover histogram selection triggering fetch (#43097)

* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error

* Adjust functional test for 7.3

* Skip functional test
This commit is contained in:
Matthias Wilhelm 2019-08-16 14:51:50 +02:00 • committed by Tim Roes
parent 46bdb77230
commit 0dc0f225ee
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/legacy/core_plugins/kibana/public/discover/controllers/discover.js
View file

@ -546,6 +546,7 @@ function discoverController(
$scope.$listen(timefilter, 'autoRefreshFetch', $scope.fetch);
$scope.$listen(timefilter, 'refreshIntervalUpdate', $scope.updateRefreshInterval);
$scope.$listen(timefilter, 'timeUpdate', $scope.updateTime);
$scope.$listen(timefilter, 'fetch', $scope.fetch);
$scope.$watchCollection('state.sort', function (sort) {
if (!sort) return;

10
test/functional/apps/discover/_discover.js
View file

@ -147,18 +147,20 @@ export default function ({ getService, getPageObjects }) {
const time = await PageObjects.timePicker.getTimeConfig();
expect(time.start).to.be('Sep 20, 2015 @ 00:00:00.000');
expect(time.end).to.be('Sep 20, 2015 @ 03:00:00.000');
const rowData = await PageObjects.discover.getDocTableIndex(1);
expect(rowData).to.have.string('Sep 20, 2015 @ 02:57:03.761');
});
it('should modify the time range when the histogram is brushed', async function () {
it.skip('should modify the time range when the histogram is brushed', async function () {
await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
await PageObjects.visualize.waitForVisualization();
await PageObjects.discover.brushHistogram(0, 1);
await PageObjects.visualize.waitForVisualization();
const newDurationHours = await PageObjects.timePicker.getTimeDurationInHours();
if (newDurationHours < 1 || newDurationHours >= 5) {
throw new Error(`expected new duration of ${newDurationHours} hours to be between 1 and 5 hours`);
}
expect(Math.round(newDurationHours)).to.be(3);
const rowData = await PageObjects.discover.getDocTableIndex(1);
expect(rowData).to.have.string('Sep 20, 2015 @ 02:51:53.327');
});
it('should show correct initial chart interval of Auto', async function () {