github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

reafctor

Browse source
This commit is contained in:
Ashokaditya 2023-07-07 08:30:26 +02:00
parent 0d0408cb11
commit 0e281f1191
2 changed files with 34 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

32
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/components/endpoint_list_nav_link.tsx Normal file
View file

@ -0,0 +1,32 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React, { memo } from 'react';
import { EuiLink } from '@elastic/eui';
import { useNavigateByRouterEventHandler } from '../../../../../common/hooks/endpoint/use_navigate_by_router_event_handler';
export const EndpointListNavLink = memo<{
name: string;
href: string;
route: string;
dataTestSubj: string;
}>(({ name, href, route, dataTestSubj }) => {
const clickHandler = useNavigateByRouterEventHandler(route);
return (
// eslint-disable-next-line @elastic/eui/href-or-on-click
<EuiLink
data-test-subj={dataTestSubj}
className="eui-displayInline eui-textTruncate"
href={href}
onClick={clickHandler}
>
{name}
</EuiLink>
);
});
EndpointListNavLink.displayName = 'EndpointListNavLink';

25
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx
View file

@ -5,7 +5,7 @@
* 2.0.
*/
import React, { memo, useCallback, useEffect, useMemo, useState } from 'react';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import styled from 'styled-components';
import type { EuiBasicTableColumn, EuiSelectableProps } from '@elastic/eui';
import {
@ -29,6 +29,7 @@ import type {
AgentPolicyDetailsDeployAgentAction,
CreatePackagePolicyRouteState,
} from '@kbn/fleet-plugin/public';
import { EndpointListNavLink } from './components/endpoint_list_nav_link';
import { EndpointAgentStatus } from '../../../../common/components/endpoint/endpoint_agent_status';
import { EndpointDetailsFlyout } from './details';
import * as selectors from '../store/selectors';
@ -36,7 +37,6 @@ import { getEndpointPendingActionsCallback } from '../store/selectors';
import { useEndpointSelector } from './hooks';
import { isPolicyOutOfDate } from '../utils';
import { POLICY_STATUS_TO_HEALTH_COLOR, POLICY_STATUS_TO_TEXT } from './host_constants';
import { useNavigateByRouterEventHandler } from '../../../../common/hooks/endpoint/use_navigate_by_router_event_handler';
import type { CreateStructuredSelector } from '../../../../common/store';
import type {
HostInfo,
@ -79,27 +79,6 @@ const StyledDatePicker = styled.div`
background-color: rgba(0, 119, 204, 0.2);
}
`;
const EndpointListNavLink = memo<{
name: string;
href: string;
route: string;
dataTestSubj: string;
}>(({ name, href, route, dataTestSubj }) => {
const clickHandler = useNavigateByRouterEventHandler(route);
return (
// eslint-disable-next-line @elastic/eui/href-or-on-click
<EuiLink
data-test-subj={dataTestSubj}
className="eui-displayInline eui-textTruncate"
href={href}
onClick={clickHandler}
>
{name}
</EuiLink>
);
});
EndpointListNavLink.displayName = 'EndpointListNavLink';
// FIXME: this needs refactoring - we are pulling in all selectors from endpoint, which includes many more than what the list uses
const selector = (createStructuredSelector as CreateStructuredSelector)(selectors);