[Code] Disable xpack.code.ui.enabled instead of xpack.code.enabled (#38919) (#41320) (#44635)

* [Code] Disable xpack.code.ui.enabled instead of xpack.code.enabled

* Revert "[Code]: disable code by default in 7.2 (#38757) (#38801)"

x-pack/legacy/plugins/code/index.ts

@@ -59,7 +59,7 @@ export const code = (kibana: any) =>
       });
       return Joi.object({
         ui: Joi.object({
-          enabled: Joi.boolean().default(true),
+          enabled: Joi.boolean().default(false),
         }).default(),
         enabled: Joi.boolean().default(true),
         queueIndex: Joi.string().default('.code_internal-worker-queue'),

x-pack/legacy/plugins/code/server/__tests__/multi_node.ts

@@ -89,7 +89,13 @@ describe.skip('code in multiple nodes', () => {
             port: codePort,
           },
           plugins: { paths: [pluginPaths] },
-          xpack: { ...xpackOption, code: { codeNodeUrl: `http://localhost:${codePort}` } },
+          xpack: {
+            ...xpackOption,
+            code: {
+              codeNodeUrl: `http://localhost:${codePort}`,
+              ui: { enabled: true },
+            },
+          },
           logging: { silent: false },
         },
       },
@@ -109,7 +115,10 @@ describe.skip('code in multiple nodes', () => {
       plugins: { paths: [pluginPaths] },
       xpack: {
         ...xpackOption,
-        code: { codeNodeUrl: `http://localhost:${codePort}` },
+        code: {
+          ui: { enabled: true },
+          codeNodeUrl: `http://localhost:${codePort}`,
+        },
       },
       logging: { silent: true },
     };

x-pack/test/api_integration/config.js

@@ -22,6 +22,7 @@ export async function getApiIntegrationConfig({ readConfigFile }) {
       serverArgs: [
         ...xPackFunctionalTestsConfig.get('kbnTestServer.serverArgs'),
         '--optimize.enabled=false',
+        '--xpack.code.ui.enabled=true' // Enable Code Ui just in tests
       ],
     },
     esTestCluster: {

x-pack/test/functional/config.js

@@ -84,6 +84,7 @@ export default async function ({ readConfigFile }) {
         '--stats.maximumWaitTimeForAllCollectorsInS=0',
         '--xpack.security.encryptionKey="wuGNaIhoMpk5sO4UBxgr3NyW1sFcLgIf"', // server restarts should not invalidate active sessions
         '--xpack.encrypted_saved_objects.encryptionKey="DkdXazszSCYexXqz4YktBGHCRkV6hyNK"',
+        '--xpack.code.ui.enabled=true', // Enable Code UI just in tests
         '--timelion.ui.enabled=true',
       ],
     },