add some tests around marker creation

src/kibana/components/vislib/visualizations/_map.js

@@ -168,14 +168,12 @@ define(function (require) {
      * creates featurelayer from mapData (geoJson)
      *
      * @method _addMarkers
-     * @return {Leaflet featureLayer} marker layer
      */
     Map.prototype._addMarkers = function () {
       if (!this._geoJson) return;
       if (this._markers) this._markers.destroy();
 
-      var MarkerType = markerTypes[this._markerType];
-      this._markers = new MarkerType(this.map, this._geoJson, {
+      this._markers = this._createMarkers({
         tooltipFormatter: this._tooltipFormatter,
         valueFormatter: this._valueFormatter,
         attr: this._attr
@@ -186,6 +184,18 @@ define(function (require) {
       }
     };
 
+    /**
+     * Create the marker instance using the given options
+     *
+     * @method _createMarkers
+     * @param options {Object} options to give to marker class
+     * @return {Object} marker layer
+     */
+    Map.prototype._createMarkers = function (options) {
+      var MarkerType = markerTypes[this._markerType];
+      return new MarkerType(this.map, this._geoJson, options);
+    };
+
     Map.prototype._attachEvents = function () {
       var self = this;
       var saturateTiles = self.saturateTiles.bind(self);

test/unit/specs/vislib/visualizations/tile_maps/map.js

@@ -103,7 +103,7 @@ define(function (require) {
       });
     });
 
-    describe('attach events', function () {
+    describe('attachEvents', function () {
       var map;
 
       beforeEach(function () {
@@ -136,5 +136,34 @@ define(function (require) {
         expect(matchedEvents.maps).to.equal(expectedMapEvents.length);
       });
     });
+
+
+    describe('addMarkers', function () {
+      var map;
+      var createStub;
+
+      beforeEach(function () {
+        sinon.stub(Map.prototype, '_createMap');
+        createStub = sinon.stub(Map.prototype, '_createMarkers', _.constant({ addLegend: _.noop }));
+        map = new Map($mockMapEl, geoJsonData, {});
+      });
+
+      it('should pass the map options to the marker', function () {
+        map._addMarkers();
+
+        var args = createStub.firstCall.args[0];
+        expect(args).to.have.property('tooltipFormatter');
+        expect(args).to.have.property('valueFormatter');
+        expect(args).to.have.property('attr');
+      });
+
+      it('should destroy existing markers', function () {
+        var destroyStub = sinon.stub();
+        map._markers = { destroy: destroyStub };
+        map._addMarkers();
+
+        expect(destroyStub.callCount).to.be(1);
+      });
+    });
   });
 });