[kbn-es] Security updates (#36288) (#36299)

* In kbn-test, provide password to cluster.start()
* Security enabled by default, overwrite by passing `-E "xpack.security.enabled=false"`

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

packages/kbn-es/src/cluster.js

@@ -151,6 +151,7 @@ exports.Cluster = class Cluster {
    * @param {String} installPath
    * @param {Object} options
    * @property {Array} options.esArgs
+   * @property {String} options.password - super user password used to bootstrap
    * @returns {Promise}
    */
   async start(installPath, options = {}) {

packages/kbn-es/src/install/archive.js

@@ -62,13 +62,11 @@ exports.installArchive = async function installArchive(archive, options = {}) {
   await decompress(dest, installPath);
   log.info('extracted to %s', chalk.bold(installPath));
 
-  if (license === 'trial') {
+  if (license !== 'oss') {
     // starting in 6.3, security is disabled by default. Since we bootstrap
     // the keystore, we can enable security ourselves.
     await appendToConfig(installPath, 'xpack.security.enabled', 'true');
-  }
 
-  if (license !== 'oss') {
     await appendToConfig(installPath, 'xpack.license.self_generated.type', license);
     await configureKeystore(installPath, password, log);
   }

packages/kbn-test/src/es/es_test_cluster.js

@@ -80,6 +80,7 @@ export function createEsTestCluster(options = {}) {
       }
 
       await cluster.start(installPath, {
+        password: config.password,
         esArgs: [
           `cluster.name=${clusterName}`,
           `http.port=${port}`,