github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 01:13:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix(bug): fixed sorting on cluster list table (#151372)

Browse source 
## Summary

Going to Stack Monitoring in Kibana will bring you to the cluster list.
Attempt to click one of the table headings to sort by that field.

Expected behavior: The table values are sorted by that field
Actual behavior: It changes the direction of the sort on Name

closes [#147273](https://github.com/elastic/kibana/issues/147273)

### Testing


https://user-images.githubusercontent.com/11225826/219131518-7a9b341a-3b6e-4a46-a680-a1d2a12b2bb1.mov
This commit is contained in:
mohamedhamed-ahmed 2023-02-16 09:23:27 +00:00 • committed by GitHub
parent 17beb0e647
commit 108b4b512b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

21
x-pack/plugins/monitoring/public/components/cluster/listing/listing.js
View file

@ -389,17 +389,21 @@ const StandaloneClusterCallout = ({ changeCluster, storage }) => {
};
export const Listing = ({ angular, clusters, sorting, pagination, onTableChange }) => {
const { scope, globalState, storage, showLicenseExpiration } = angular;
const {
sort: { direction, field },
} = sorting;
const { services } = useKibana();
const _changeCluster = partial(changeCluster, angular.scope, angular.globalState);
const _changeCluster = partial(changeCluster, scope, globalState);
const _handleClickIncompatibleLicense = partial(
handleClickIncompatibleLicense,
angular.scope,
scope,
services.theme.theme$
);
const _handleClickInvalidLicense = partial(
handleClickInvalidLicense,
angular.scope,
scope,
services.theme.theme$
);
const hasStandaloneCluster = !!clusters.find(
@ -411,13 +415,13 @@ export const Listing = ({ angular, clusters, sorting, pagination, onTableChange
<EuiPageBody>
<EuiPageContent>
{hasStandaloneCluster ? (
<StandaloneClusterCallout changeCluster={_changeCluster} storage={angular.storage} />
<StandaloneClusterCallout changeCluster={_changeCluster} storage={storage} />
) : null}
<EuiMonitoringTable
className="clusterTable"
rows={clusters}
columns={getColumns(
angular.showLicenseExpiration,
showLicenseExpiration,
_changeCluster,
_handleClickIncompatibleLicense,
_handleClickInvalidLicense
@ -428,17 +432,16 @@ export const Listing = ({ angular, clusters, sorting, pagination, onTableChange
};
}}
sorting={{
...sorting,
sort: {
...sorting.sort,
field: 'cluster_name',
direction,
field: field || 'cluster_name',
},
}}
pagination={pagination}
search={{
box: {
incremental: true,
placeholder: angular.scope.filterText,
placeholder: scope.filterText,
},
}}
onTableChange={onTableChange}