mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 09:19:04 -04:00
Address feedback
This commit is contained in:
parent
bd1ff1c677
commit
117d8c8c4e
6 changed files with 9 additions and 10 deletions
|
@ -6,7 +6,7 @@
|
|||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
import React, { FC, useMemo } from 'react';
|
||||
import React, { FC } from 'react';
|
||||
import type { I18nStart } from '@kbn/core-i18n-browser';
|
||||
import { composeProviders, KibanaThemeProvider } from '@kbn/react-kibana-context';
|
||||
import { ThemeServiceStart } from '@kbn/core-theme-browser/src/types';
|
||||
|
@ -26,7 +26,7 @@ export const CoreContextProvider: FC<CoreContextProviderProps> = ({
|
|||
theme,
|
||||
globalStyles = false,
|
||||
}) => {
|
||||
const Provider = useMemo(() => composeProviders([i18n.Context, KibanaThemeProvider]), [i18n]);
|
||||
const Provider = composeProviders([i18n.Context, KibanaThemeProvider]);
|
||||
|
||||
return (
|
||||
<Provider theme$={theme.theme$} {...{ globalStyles }}>
|
||||
|
|
|
@ -13,5 +13,6 @@ import { KibanaThemeProvider } from '@kbn/react-kibana-context';
|
|||
* @internal Only meant to be used within core for internal usages of EUI/React
|
||||
* @deprecated use `KibanaThemeProvider` from `@kbn/react-kibana-context
|
||||
*/
|
||||
export const CoreThemeProvider = KibanaThemeProvider.bind(undefined);
|
||||
CoreThemeProvider.displayName = 'CoreThemeProvider';
|
||||
export const CoreThemeProvider = Object.assign(KibanaThemeProvider, {
|
||||
displayName: 'CoreThemeProvider',
|
||||
});
|
||||
|
|
|
@ -16,7 +16,6 @@
|
|||
"target/**/*"
|
||||
],
|
||||
"kbn_references": [
|
||||
"@kbn/i18n-react",
|
||||
"@kbn/test-jest-helpers",
|
||||
]
|
||||
}
|
||||
|
|
|
@ -5,8 +5,7 @@
|
|||
* in compliance with, at your election, the Elastic License 2.0 or the Server
|
||||
* Side Public License, v 1.
|
||||
*/
|
||||
|
||||
import { KibanaThemeProvider as _KibanaThemeProvider } from '@kbn/react-kibana-context';
|
||||
|
||||
/** @deprecated use `KibanaThemeProvider` from `@kbn/react-kibana-context */
|
||||
export const KibanaThemeProvider = _KibanaThemeProvider;
|
||||
export {
|
||||
/** @deprecated use `KibanaThemeProvider` from `@kbn/react-kibana-context */
|
||||
KibanaThemeProvider,
|
||||
} from '@kbn/react-kibana-context';
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue