github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Search] Fix duration bug (#184110)

Browse source 
## Summary

This fixes a bug in connector sync durations where hours would wrap
around to 0 after one day.
This commit is contained in:
Sander Philipse 2024-05-30 16:17:21 +02:00 • committed by GitHub
parent ce4375f770
commit 123cbca48d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/kbn-search-connectors/utils/duration_to_text.test.ts
View file

@ -14,6 +14,9 @@ describe('durationToText', () => {
it('should correctly turn duration into text', () => {
expect(durationToText(moment.duration(11005, 'seconds'))).toEqual('3h 3m 25s');
});
it('should correctly turn days into hours', () => {
expect(durationToText(moment.duration(100980, 'seconds'))).toEqual('28h 3m 0s');
});
it('should return -- for undefined', () => {
expect(durationToText(undefined)).toEqual('--');
});

3
packages/kbn-search-connectors/utils/duration_to_text.ts
View file

@ -17,10 +17,11 @@ export function getSyncJobDuration(syncJob: ConnectorSyncJob): moment.Duration |
export function durationToText(input?: moment.Duration): string {
if (input) {
const days = input.days();
const hours = input.hours();
const minutes = input.minutes();
const seconds = input.seconds();
return `${hours}h ${minutes}m ${seconds}s`;
return `${hours + days * 24}h ${minutes}m ${seconds}s`;
} else {
return '--';
}