[Discover] Remove state persistAdHocDataView (#158227)

Eliminating code that's no longer in use
This commit is contained in:
Matthias Wilhelm 2023-05-23 10:09:16 +02:00 committed by GitHub
parent 301135bff8
commit 12da3d0721
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -170,11 +170,6 @@ export interface DiscoverStateContainer {
* @param id - id of the data view
*/
onChangeDataView: (id: string) => Promise<void>;
/**
* Triggered when an ad-hoc data view is persisted to allow sharing links and CSV
* @param dataView
*/
persistAdHocDataView: (dataView: DataView) => Promise<DataView>;
/**
* Set the currently selected data view
* @param dataView
@ -325,18 +320,6 @@ export function getDiscoverStateContainer({
fetchData();
};
const persistAdHocDataView = async (adHocDataView: DataView) => {
const persistedDataView = await services.dataViews.createAndSave({
...adHocDataView.toSpec(),
id: uuidv4(),
});
services.dataViews.clearInstanceCache(adHocDataView.id);
updateFiltersReferences(adHocDataView, persistedDataView);
internalStateContainer.transitions.removeAdHocDataViewById(adHocDataView.id!);
await appStateContainer.update({ index: persistedDataView.id }, true);
return persistedDataView;
};
const loadSavedSearch = async (params?: LoadParams): Promise<SavedSearch> => {
return loadSavedSearchFn(params ?? {}, {
appStateContainer,
@ -483,7 +466,6 @@ export function getDiscoverStateContainer({
onDataViewEdited,
onOpenSavedSearch,
onUpdateQuery,
persistAdHocDataView,
setDataView,
undoSavedSearchChanges,
updateAdHocDataViewId,