github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Maps] fix adding filters in map embeddable (#45187) (#45579)

Browse source
This commit is contained in:
Nathan Reese 2019-09-12 16:53:29 -06:00 • committed by GitHub
parent dee51ceac2
commit 130432e93c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/legacy/plugins/maps/public/embeddable/map_embeddable.js
View file

@ -138,9 +138,7 @@ export class MapEmbeddable extends Embeddable {
addFilters = filters => {
start.executeTriggerActions(APPLY_FILTER_TRIGGER, {
embeddable: this,
triggerContext: {
filters,
},
filters,
});
}

9
x-pack/test/functional/apps/maps/embeddable/tooltip_filter_actions.js
View file

@ -10,7 +10,7 @@ export default function ({ getPageObjects, getService }) {
const PageObjects = getPageObjects(['common', 'dashboard', 'maps']);
const kibanaServer = getService('kibanaServer');
const testSubjects = getService('testSubjects');
// const filterBar = getService('filterBar');
const filterBar = getService('filterBar');
describe('tooltip filter actions', () => {
@ -29,11 +29,6 @@ export default function ({ getPageObjects, getService }) {
expect(exists).to.be(true);
});
/**
* @todo Re-enable this test when https://github.com/elastic/kibana/pull/41272#issuecomment-519868543
* is resolved.
*/
/*
it('should create filters when create filter button is clicked', async () => {
await testSubjects.click('mapTooltipCreateFilterButton');
@ -43,7 +38,5 @@ export default function ({ getPageObjects, getService }) {
const hasJoinFilter = await filterBar.hasFilter('shape_name', 'charlie');
expect(hasJoinFilter).to.be(true);
});
*/
});
}