chore(NA): enable @typescript-eslint/explicit-member-accessibility rule (#41422) (#41579)

packages/eslint-config-kibana/package.json

@@ -15,8 +15,8 @@
   },
   "homepage": "https://github.com/elastic/eslint-config-kibana#readme",
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "1.11.0",
-    "@typescript-eslint/parser": "1.11.0",
+    "@typescript-eslint/eslint-plugin": "1.12.0",
+    "@typescript-eslint/parser": "1.12.0",
     "babel-eslint": "10.0.2",
     "eslint": "5.16.0",
     "eslint-plugin-babel": "5.3.0",

packages/eslint-config-kibana/typescript.js

@@ -80,10 +80,16 @@ module.exports = {
             'allow': ['^[A-Z0-9_]+$']
           }],
           '@typescript-eslint/class-name-casing': 'error',
-          // TODO: disable this rule until a PR with more options to configure
-          //       get merged and we can then reproduce the old behaviour
-          // https://github.com/typescript-eslint/typescript-eslint/pull/322
-          // '@typescript-eslint/explicit-member-accessibility': 'error',
+          '@typescript-eslint/explicit-member-accessibility': ['error',
+            {
+              accessibility: 'off',
+              overrides: {
+                accessors: 'explicit',
+                constructors: 'no-public',
+                parameterProperties: 'explicit'
+              }
+            }
+          ],
           'indent': 'off',
           '@typescript-eslint/indent': [ 'error', 2, { SwitchCase: 1 } ],
           '@typescript-eslint/prefer-function-type': 'error',

packages/kbn-pm/src/utils/project.ts

@@ -85,7 +85,7 @@ export class Project {
     this.scripts = this.json.scripts || {};
   }
 
-  get name(): string {
+  public get name(): string {
     return this.json.name;
   }
 

src/core/public/chrome/chrome_service.tsx

@@ -88,7 +88,7 @@ export class ChromeService {
   private readonly navLinks = new NavLinksService();
   private readonly recentlyAccessed = new RecentlyAccessedService();
 
-  public constructor({ browserSupportsCsp }: ConstructorParams) {
+  constructor({ browserSupportsCsp }: ConstructorParams) {
     this.browserSupportsCsp = browserSupportsCsp;
   }
 

src/core/public/chrome/recently_accessed/recently_accessed_service.test.ts

@@ -46,7 +46,7 @@ class LocalStorageMock implements Storage {
     return [...this.store.keys()][index] || null;
   }
 
-  get length() {
+  public get length() {
     return this.store.size;
   }
 }

src/core/public/http/http_intercept_controller.ts

@@ -20,7 +20,7 @@
 export class HttpInterceptController {
   private _halted = false;
 
-  get halted() {
+  public get halted() {
     return this._halted;
   }
 

src/core/server/http/base_path_proxy_server.ts

@@ -37,11 +37,11 @@ export class BasePathProxyServer {
   private server?: Server;
   private httpsAgent?: HttpsAgent;
 
-  get basePath() {
+  public get basePath() {
     return this.httpConfig.basePath;
   }
 
-  get targetPort() {
+  public get targetPort() {
     return this.devConfig.basePathProxyTargetPort;
   }
 

src/legacy/core_plugins/data/public/filter/apply_filters/apply_filters_popover.tsx

@@ -50,7 +50,7 @@ export class ApplyFiltersPopover extends Component<Props, State> {
     filters: [],
   };
 
-  public constructor(props: Props) {
+  constructor(props: Props) {
     super(props);
     this.state = {
       isFilterSelected: props.filters.map(() => true),

src/legacy/core_plugins/data/public/filter/filter_bar/filter_editor/index.tsx

@@ -74,7 +74,7 @@ interface State {
 }
 
 class FilterEditorUI extends Component<Props, State> {
-  public constructor(props: Props) {
+  constructor(props: Props) {
     super(props);
     this.state = {
       selectedIndexPattern: this.getIndexPatternFromFilter(),

src/legacy/core_plugins/data/public/filter/filter_bar/filter_editor/range_value_input.tsx

@@ -41,7 +41,7 @@ interface Props {
 }
 
 class RangeValueInputUI extends Component<Props> {
-  public constructor(props: Props) {
+  constructor(props: Props) {
     super(props);
   }
 

src/legacy/core_plugins/elasticsearch/index.d.ts

@@ -150,7 +150,7 @@ import {
 export class Cluster {
   public callWithRequest: CallClusterWithRequest;
   public callWithInternalUser: CallCluster;
-  public constructor(config: ClusterConfig);
+  constructor(config: ClusterConfig);
 }
 
 export interface ClusterConfig {

src/legacy/core_plugins/embeddable_api/public/test_samples/embeddables/hello_world_container_component.tsx

@@ -37,7 +37,7 @@ export class HelloWorldContainerComponent extends Component<Props, State> {
   private inputSubscription?: Subscription;
   private outputSubscription?: Subscription;
 
-  public constructor(props: Props) {
+  constructor(props: Props) {
     super(props);
 
     Object.values(this.props.container.getInput().panels).forEach(panelState => {

src/test_utils/public/stub_browser_storage.ts

@@ -27,7 +27,7 @@ export class StubBrowserStorage {
   // Browser-specific methods.
   // -----------------------------------------------------------------------------------------------
 
-  get length() {
+  public get length() {
     return this.keys.length;
   }
 

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/app/dashboard_container_example.tsx

@@ -43,7 +43,7 @@ export class DashboardContainerExample extends React.Component<{}, State> {
   private mounted = false;
   private container: DashboardContainer | ErrorEmbeddable | undefined;
 
-  public constructor() {
+  constructor() {
     super({});
     this.state = {
       viewMode: ViewMode.VIEW,

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/app/hello_world_container_example.tsx

@@ -36,7 +36,7 @@ export class HelloWorldContainerExample extends React.Component<Props, { lastNam
   private mounted: boolean = false;
   private subscription?: Subscription;
 
-  public constructor(props: Props) {
+  constructor(props: Props) {
     super(props);
 
     this.container = new HelloWorldContainer(

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/app/hello_world_embeddable_example.tsx

@@ -23,7 +23,7 @@ import { HelloWorldEmbeddable } from '../../../../../../src/legacy/core_plugins/
 export class ContactCardEmbeddableExample extends React.Component<{}> {
   private embeddable: HelloWorldEmbeddable;
 
-  public constructor() {
+  constructor() {
     super({});
     this.embeddable = new HelloWorldEmbeddable({ id: 'hello' });
   }

x-pack/legacy/plugins/beats_management/server/lib/framework.ts

@@ -53,14 +53,14 @@ export class BackendFrameworkLib {
   /**
    * Expired `null` happens when we have no xpack info
    */
-  get license() {
+  public get license() {
     return {
       type: this.adapter.info ? this.adapter.info.license.type : 'unknown',
       expired: this.adapter.info ? this.adapter.info.license.expired : null,
     };
   }
 
-  get securityIsEnabled() {
+  public get securityIsEnabled() {
     return this.adapter.info ? this.adapter.info.security.enabled : false;
   }
 

x-pack/legacy/plugins/code/public/components/main/top_bar.tsx

@@ -33,7 +33,7 @@ export class TopBar extends React.Component<Props, { value: string }> {
     value: decodeRevisionString(this.props.routeParams.revision),
   };
 
-  get branch() {
+  public get branch() {
     return this.getBranch(this.state.value);
   }
 
@@ -50,7 +50,7 @@ export class TopBar extends React.Component<Props, { value: string }> {
     }
   };
 
-  get branchOptions() {
+  public get branchOptions() {
     return this.props.branches.map(b => ({
       value: b.name,
       text: b.name,

x-pack/legacy/plugins/code/server/lsp/go_launcher.ts

@@ -16,7 +16,7 @@ import { InitializeOptions, RequestExpander } from './request_expander';
 const GO_LANG_DETACH_PORT = 2091;
 
 export class GoServerLauncher extends AbstractLauncher {
-  public constructor(
+  constructor(
     readonly targetHost: string,
     readonly options: ServerOptions,
     readonly loggerFactory: LoggerFactory

x-pack/legacy/plugins/code/server/lsp/java_launcher.ts

@@ -21,7 +21,7 @@ const JAVA_LANG_DETACH_PORT = 2090;
 
 export class JavaLauncher extends AbstractLauncher {
   private needModuleArguments: boolean = true;
-  public constructor(
+  constructor(
     readonly targetHost: string,
     readonly options: ServerOptions,
     readonly loggerFactory: LoggerFactory

x-pack/legacy/plugins/code/server/lsp/ts_launcher.ts

@@ -17,7 +17,7 @@ import { InitializeOptions, RequestExpander } from './request_expander';
 const TS_LANG_DETACH_PORT = 2089;
 
 export class TypescriptServerLauncher extends AbstractLauncher {
-  public constructor(
+  constructor(
     readonly targetHost: string,
     readonly options: ServerOptions,
     readonly loggerFactory: LoggerFactory

x-pack/legacy/plugins/siem/public/containers/query_template.tsx

@@ -40,7 +40,8 @@ export class QueryTemplate<
     tiebreaker?: string
   ) => FetchMoreOptionsArgs<TData, TVariables>;
 
-  public constructor(props: T) {
+  // eslint-disable-next-line @typescript-eslint/no-useless-constructor
+  constructor(props: T) {
     super(props);
   }
 

x-pack/legacy/plugins/siem/public/containers/query_template_paginated.tsx

@@ -37,7 +37,8 @@ export class QueryTemplatePaginated<
 
   private fetchMoreOptions!: (newActivePage: number) => FetchMoreOptionsArgs<TData, TVariables>;
 
-  public constructor(props: T) {
+  // eslint-disable-next-line @typescript-eslint/no-useless-constructor
+  constructor(props: T) {
     super(props);
   }
 

x-pack/legacy/plugins/snapshot_restore/public/app/services/http/http.ts

@@ -12,7 +12,7 @@ class HttpService {
     this.addBasePath = chrome.addBasePath.bind(chrome);
   }
 
-  get httpClient(): any {
+  public get httpClient(): any {
     return this.client;
   }
 }

x-pack/legacy/plugins/task_manager/task_manager.ts

@@ -46,7 +46,7 @@ export class TaskManager {
    * enabling the task manipulation methods, and beginning the background polling
    * mechanism.
    */
-  public constructor(kbnServer: any, server: any, config: any) {
+  constructor(kbnServer: any, server: any, config: any) {
     this.maxWorkers = config.get('xpack.task_manager.max_workers');
     this.overrideNumWorkers = config.get('xpack.task_manager.override_num_workers');
     this.definitions = {};

x-pack/legacy/plugins/task_manager/task_pool.ts

@@ -41,7 +41,7 @@ export class TaskPool {
   /**
    * Gets how many workers are currently in use.
    */
-  get occupiedWorkers() {
+  public get occupiedWorkers() {
     const running = Array.from(this.running); // get array from a Set
     return running.reduce((total, { numWorkers }) => (total += numWorkers), 0);
   }
@@ -49,7 +49,7 @@ export class TaskPool {
   /**
    * Gets how many workers are currently available.
    */
-  get availableWorkers() {
+  public get availableWorkers() {
     return this.maxWorkers - this.occupiedWorkers;
   }
 

x-pack/legacy/plugins/task_manager/task_store.ts

@@ -211,7 +211,7 @@ export class TaskStore {
     return templateResult;
   }
 
-  get isInitialized() {
+  public get isInitialized() {
     return this._isInitialized;
   }
 

x-pack/legacy/server/lib/optional_plugin.test.ts

@@ -6,7 +6,7 @@
 import { createOptionalPlugin } from './optional_plugin';
 
 class FooPlugin {
-  get aProp() {
+  public get aProp() {
     return 'a prop';
   }