Handle undefined options when looking for 'pluginDir' (#15532) (#15536)

* Handle undefined options when looking for 'pluginDir'

* Use 'settings' instead of 'options'
This commit is contained in:
Kim Joar Bekkelund 2017-12-12 01:41:49 +01:00 committed by GitHub
parent f4e94f70b0
commit 13f8bbec55
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions

View file

@ -18,7 +18,7 @@ function processCommand(command, options) {
const logger = new Logger(settings);
warnIfUsingPluginDirOption(options, fromRoot('plugins'), logger);
warnIfUsingPluginDirOption(settings, fromRoot('plugins'), logger);
logWarnings(settings, logger);
install(settings, logger);
}

View file

@ -1,5 +1,5 @@
export function warnIfUsingPluginDirOption(options, defaultValue, logger) {
if (options.pluginDir !== defaultValue) {
if (options && options.pluginDir !== defaultValue) {
logger.log(
'Warning: Using the -d, --plugin-dir option is deprecated, and is ' +
'known to not work for all plugins, including X-Pack.'

View file

@ -17,7 +17,7 @@ function processCommand(command, options) {
const logger = new Logger(settings);
warnIfUsingPluginDirOption(options, fromRoot('plugins'), logger);
warnIfUsingPluginDirOption(settings, fromRoot('plugins'), logger);
logWarnings(settings, logger);
list(settings, logger);
}

View file

@ -18,7 +18,7 @@ function processCommand(command, options) {
const logger = new Logger(settings);
warnIfUsingPluginDirOption(options, fromRoot('plugins'), logger);
warnIfUsingPluginDirOption(settings, fromRoot('plugins'), logger);
logWarnings(settings, logger);
remove(settings, logger);
}