github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove build hash from Storybook upload (#206687)

Browse source 
## Summary

After a CI run, Storybooks are built. Each commit is built and uploaded
separately, which makes sense:


https://github.com/elastic/kibana/blob/main/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L24

Unfortunately, we don't have a way to consistently point to main, or to
a PR.

## PRs

Using https://github.com/elastic/kibana/pull/206540 as an example, the
Storybook is currently hosted at:


https://ci-artifacts.kibana.dev/storybooks/pr-206540/803ec26fb200e1fd23c33ead174dcc5356262cfc

This means that, if I push another commit, the URL will change... so all
of the links I've posted in Slack are now invalid. This PR changes the
URL so it will remain:

https://ci-artifacts.kibana.dev/storybooks/pr-206540

regardless of how many commits I push.

## `main`

Furthermore, being able to visit
https://ci-artifacts.kibana.dev/storybooks/main/latest/index.html to see
the most recent Storybook build is awesome. The issue is each Storybook
is hosted with that same hash:


https://ci-artifacts.kibana.dev/storybooks/main/5ad3ef7b0a76968a31b0824bd08f9132c374c841/shared_ux/index.html

So this PR alters the URL so you can consistently point to the latest
Storybook build:

https://ci-artifacts.kibana.dev/storybooks/main/shared_ux/index.html
This commit is contained in:
Clint Andrew Hall 2025-01-15 09:37:27 -05:00 • committed by GitHub
parent 9f92c8e67f
commit 16f69b7b2d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.buildkite/scripts/steps/storybooks/build_and_upload.ts
View file

@ -21,7 +21,7 @@ const STORYBOOK_DIRECTORY =
: (process.env.BUILDKITE_BRANCH ?? '').replace('/', '__');
const STORYBOOK_BUCKET = 'ci-artifacts.kibana.dev/storybooks';
const STORYBOOK_BUCKET_URL = `https://${STORYBOOK_BUCKET}/${STORYBOOK_DIRECTORY}`;
const STORYBOOK_BASE_URL = `${STORYBOOK_BUCKET_URL}/${process.env.BUILDKITE_COMMIT}`;
const STORYBOOK_BASE_URL = `${STORYBOOK_BUCKET_URL}`;
const exec = (...args: string[]) => execSync(args.join(' '), { stdio: 'inherit' });
@ -80,7 +80,7 @@ const upload = () => {
);
exec(`
${activateScript} gs://ci-artifacts.kibana.dev
gsutil -q -m cp -r -z js,css,html,json,map,txt,svg '*' 'gs://${STORYBOOK_BUCKET}/${STORYBOOK_DIRECTORY}/${process.env.BUILDKITE_COMMIT}/'
gsutil -h "Cache-Control:no-cache, max-age=0, no-transform" -q -m cp -r -z js,css,html,json,map,txt,svg '*' 'gs://${STORYBOOK_BUCKET}/${STORYBOOK_DIRECTORY}/'
gsutil -h "Cache-Control:no-cache, max-age=0, no-transform" cp -z html 'index.html' 'gs://${STORYBOOK_BUCKET}/${STORYBOOK_DIRECTORY}/latest/'
`);