github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[junit] only include stdout in report for failures (#60530)

Browse source 
* [junit] only include stdout in report for failures

* fix assertion

Co-authored-by: spalger <spalger@users.noreply.github.com>
This commit is contained in:
Spencer 2020-03-18 17:49:40 -07:00 • committed by GitHub
parent b9d2affc73
commit 18f973ea61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/kbn-test/src/mocha/__tests__/junit_report_generation.js
View file

@ -129,7 +129,7 @@ describe('dev/mocha/junit report generation', () => {
name: 'SUITE SUB_SUITE never runs',
'metadata-json': '{}',
},
'system-out': testFail['system-out'],
'system-out': ['-- logs are only reported for failed tests --'],
skipped: [''],
});
});

4
packages/kbn-test/src/mocha/junit_report_generation.js
View file

@ -126,13 +126,15 @@ export function setupJUnitReportGeneration(runner, options = {}) {
[...results, ...skippedResults].forEach(result => {
const el = addTestcaseEl(result.node);
el.ele('system-out').dat(escapeCdata(getSnapshotOfRunnableLogs(result.node) || ''));
if (result.failed) {
el.ele('system-out').dat(escapeCdata(getSnapshotOfRunnableLogs(result.node) || ''));
el.ele('failure').dat(escapeCdata(inspect(result.error)));
return;
}
el.ele('system-out').dat('-- logs are only reported for failed tests --');
if (result.skipped) {
el.ele('skipped');
}