github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

support local data views in runtime field editor (#134756)

Browse source
This commit is contained in:
Peter Pisljar 2022-06-28 07:41:24 +02:00 • committed by GitHub
parent ecd0933e8a
commit 1916efbb1c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/plugins/data_view_field_editor/public/components/field_editor_flyout_content_container.tsx
View file

@ -158,7 +158,7 @@ export const FieldEditorFlyoutContentContainer = ({
dataView.deleteFieldFormat(updatedField.name);
}
await dataViews.updateSavedObject(dataView).then(() => {
const afterSave = () => {
const message = i18n.translate('indexPatternFieldEditor.deleteField.savedHeader', {
defaultMessage: "Saved '{fieldName}'",
values: { fieldName: updatedField.name },
@ -166,6 +166,15 @@ export const FieldEditorFlyoutContentContainer = ({
notifications.toasts.addSuccess(message);
setIsSaving(false);
onSave(editedField);
};
if (!dataView.isPersisted()) {
afterSave();
return;
}
await dataViews.updateSavedObject(dataView).then(() => {
afterSave();
});
} catch (e) {
const title = i18n.translate('indexPatternFieldEditor.save.errorTitle', {

4
src/plugins/data_view_field_editor/public/lib/remove_fields.ts
View file

@ -32,7 +32,9 @@ export async function removeFields(
} catch {}
try {
await services.dataViews.updateSavedObject(dataView);
if (dataView.isPersisted()) {
await services.dataViews.updateSavedObject(dataView);
}
} catch (e) {
const title = i18n.translate('indexPatternFieldEditor.save.deleteErrorTitle', {
defaultMessage: 'Failed to save field removal',

5
src/plugins/data_view_field_editor/public/plugin.test.tsx
View file

@ -113,7 +113,10 @@ describe('DataViewFieldEditorPlugin', () => {
};
const { openDeleteModal } = await plugin.start(coreStartMocked, pluginStartMocked);
const indexPatternMock = { removeRuntimeField: removeFieldSpy } as unknown as DataView;
const indexPatternMock = {
removeRuntimeField: removeFieldSpy,
isPersisted: () => true,
} as unknown as DataView;
openDeleteModal({
onDelete: onDeleteSpy,