github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove dirty prompt from Logstash Pipeline Management (#19649)

Browse source 
* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue.

* Remove test for removed feature.
This commit is contained in:
Justin Kambic 2018-06-05 12:30:11 -04:00 • committed by GitHub
parent a4285916dd
commit 194e427bc8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/logstash/public/sections/pipeline_edit/components/pipeline_edit/pipeline_edit.js
View file

@ -8,7 +8,6 @@ import { isEmpty } from 'lodash';
import { uiModules } from 'ui/modules';
import { InitAfterBindingsWorkaround } from 'ui/compat';
import { Notifier, toastNotifications } from 'ui/notify';
import 'ui/dirty_prompt';
import template from './pipeline_edit.html';
import 'plugins/logstash/services/license';
import 'plugins/logstash/services/security';
@ -25,7 +24,6 @@ app.directive('pipelineEdit', function ($injector) {
const securityService = $injector.get('logstashSecurityService');
const kbnUrl = $injector.get('kbnUrl');
const confirmModal = $injector.get('confirmModal');
const dirtyPrompt = $injector.get('dirtyPrompt');
return {
restrict: 'E',
@ -71,11 +69,6 @@ app.directive('pipelineEdit', function ($injector) {
}
this.tooltips = TOOLTIPS;
dirtyPrompt.register(
() => !this.pipeline.isEqualTo(this.originalPipeline)
);
$scope.$on('$destroy', dirtyPrompt.deregister);
}
onPipelineSave = username => {
@ -124,7 +117,6 @@ app.directive('pipelineEdit', function ($injector) {
};
close = () => {
dirtyPrompt.deregister();
kbnUrl.change('/management/logstash/pipelines', {});
};

14
x-pack/test/functional/apps/logstash/pipeline_create.js
View file

@ -13,7 +13,6 @@ export default function ({ getService, getPageObjects }) {
const pipelineList = getService('pipelineList');
const pipelineEditor = getService('pipelineEditor');
const PageObjects = getPageObjects(['logstash']);
const testSubjects = getService('testSubjects');
describe('pipeline create new', () => {
let originalWindowSize;
@ -94,18 +93,5 @@ export default function ({ getService, getPageObjects }) {
await pipelineEditor.assertNoDeleteButton();
});
});
describe('breadcrumbs navigation', () => {
it('prompts the user about unsaved changes', async () => {
await PageObjects.logstash.gotoNewPipelineEditor();
const description = random.text();
await pipelineEditor.setDescription(description);
await pipelineEditor.clickManagementBreadcrumb();
await pipelineEditor.assertUnsavedChangesModal();
await testSubjects.click('confirmModalConfirmButton');
});
});
});
}