[Synthetics] remove feature flag (#138954)

* synthetics - remove feature flag

* remove extra translations

* skip synthetics tests

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>

src/plugins/kibana_usage_collection/server/collectors/application_usage/schema.ts

@@ -167,6 +167,5 @@ export const applicationUsageSchema = {
   siem: commonSchema,
   space_selector: commonSchema,
   uptime: commonSchema,
-  synthetics: commonSchema,
   ux: commonSchema,
 };

src/plugins/kibana_usage_collection/server/collectors/management/schema.ts

@@ -418,10 +418,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
-  'observability:enableNewSyntheticsView': {
-    type: 'boolean',
-    _meta: { description: 'Non-default value of setting.' },
-  },
   'observability:maxSuggestions': {
     type: 'integer',
     _meta: { description: 'Non-default value of setting.' },

src/plugins/kibana_usage_collection/server/collectors/management/types.ts

@@ -38,7 +38,6 @@ export interface UsageStats {
   'discover:maxDocFieldsDisplayed': number;
   'securitySolution:rulesTableRefresh': string;
   'observability:enableInspectEsQueries': boolean;
-  'observability:enableNewSyntheticsView': boolean;
   'observability:maxSuggestions': number;
   'observability:enableComparisonByDefault': boolean;
   'observability:enableInfrastructureView': boolean;

src/plugins/telemetry/schema/oss_plugins.json

@@ -6022,137 +6022,6 @@
             }
           }
         },
-        "synthetics": {
-          "properties": {
-            "appId": {
-              "type": "keyword",
-              "_meta": {
-                "description": "The application being tracked"
-              }
-            },
-            "viewId": {
-              "type": "keyword",
-              "_meta": {
-                "description": "Always `main`"
-              }
-            },
-            "clicks_total": {
-              "type": "long",
-              "_meta": {
-                "description": "General number of clicks in the application since we started counting them"
-              }
-            },
-            "clicks_7_days": {
-              "type": "long",
-              "_meta": {
-                "description": "General number of clicks in the application over the last 7 days"
-              }
-            },
-            "clicks_30_days": {
-              "type": "long",
-              "_meta": {
-                "description": "General number of clicks in the application over the last 30 days"
-              }
-            },
-            "clicks_90_days": {
-              "type": "long",
-              "_meta": {
-                "description": "General number of clicks in the application over the last 90 days"
-              }
-            },
-            "minutes_on_screen_total": {
-              "type": "float",
-              "_meta": {
-                "description": "Minutes the application is active and on-screen since we started counting them."
-              }
-            },
-            "minutes_on_screen_7_days": {
-              "type": "float",
-              "_meta": {
-                "description": "Minutes the application is active and on-screen over the last 7 days"
-              }
-            },
-            "minutes_on_screen_30_days": {
-              "type": "float",
-              "_meta": {
-                "description": "Minutes the application is active and on-screen over the last 30 days"
-              }
-            },
-            "minutes_on_screen_90_days": {
-              "type": "float",
-              "_meta": {
-                "description": "Minutes the application is active and on-screen over the last 90 days"
-              }
-            },
-            "views": {
-              "type": "array",
-              "items": {
-                "properties": {
-                  "appId": {
-                    "type": "keyword",
-                    "_meta": {
-                      "description": "The application being tracked"
-                    }
-                  },
-                  "viewId": {
-                    "type": "keyword",
-                    "_meta": {
-                      "description": "The application view being tracked"
-                    }
-                  },
-                  "clicks_total": {
-                    "type": "long",
-                    "_meta": {
-                      "description": "General number of clicks in the application sub view since we started counting them"
-                    }
-                  },
-                  "clicks_7_days": {
-                    "type": "long",
-                    "_meta": {
-                      "description": "General number of clicks in the active application sub view over the last 7 days"
-                    }
-                  },
-                  "clicks_30_days": {
-                    "type": "long",
-                    "_meta": {
-                      "description": "General number of clicks in the active application sub view over the last 30 days"
-                    }
-                  },
-                  "clicks_90_days": {
-                    "type": "long",
-                    "_meta": {
-                      "description": "General number of clicks in the active application sub view over the last 90 days"
-                    }
-                  },
-                  "minutes_on_screen_total": {
-                    "type": "float",
-                    "_meta": {
-                      "description": "Minutes the application sub view is active and on-screen since we started counting them."
-                    }
-                  },
-                  "minutes_on_screen_7_days": {
-                    "type": "float",
-                    "_meta": {
-                      "description": "Minutes the application is active and on-screen active application sub view over the last 7 days"
-                    }
-                  },
-                  "minutes_on_screen_30_days": {
-                    "type": "float",
-                    "_meta": {
-                      "description": "Minutes the application is active and on-screen active application sub view over the last 30 days"
-                    }
-                  },
-                  "minutes_on_screen_90_days": {
-                    "type": "float",
-                    "_meta": {
-                      "description": "Minutes the application is active and on-screen active application sub view over the last 90 days"
-                    }
-                  }
-                }
-              }
-            }
-          }
-        },
         "ux": {
           "properties": {
             "appId": {
@@ -8264,12 +8133,6 @@
             "description": "Non-default value of setting."
           }
         },
-        "observability:enableNewSyntheticsView": {
-          "type": "boolean",
-          "_meta": {
-            "description": "Non-default value of setting."
-          }
-        },
         "observability:maxSuggestions": {
           "type": "integer",
           "_meta": {

x-pack/plugins/observability/common/ui_settings_keys.ts

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-export const enableNewSyntheticsView = 'observability:enableNewSyntheticsView';
 export const enableInspectEsQueries = 'observability:enableInspectEsQueries';
 export const maxSuggestions = 'observability:maxSuggestions';
 export const enableComparisonByDefault = 'observability:enableComparisonByDefault';

x-pack/plugins/observability/public/index.ts

@@ -29,7 +29,6 @@ export {
   enableComparisonByDefault,
   enableInfrastructureView,
   enableServiceGroups,
-  enableNewSyntheticsView,
   apmServiceGroupMaxNumberOfServices,
 } from '../common/ui_settings_keys';
 export { uptimeOverviewLocatorID } from '../common';

x-pack/plugins/observability/server/ui_settings.ts

@@ -18,7 +18,6 @@ import {
   apmProgressiveLoading,
   enableServiceGroups,
   apmServiceInventoryOptimizedSorting,
-  enableNewSyntheticsView,
   apmServiceGroupMaxNumberOfServices,
   apmTraceExplorerTab,
   apmOperationsTab,
@@ -35,22 +34,6 @@ const technicalPreviewLabel = i18n.translate(
  * uiSettings definitions for Observability.
  */
 export const uiSettings: Record<string, UiSettingsParams<boolean | number | string>> = {
-  [enableNewSyntheticsView]: {
-    category: [observabilityFeatureId],
-    name: i18n.translate('xpack.observability.enableNewSyntheticsViewExperimentName', {
-      defaultMessage: 'Enable new synthetic monitoring application',
-    }),
-    value: false,
-    description: i18n.translate(
-      'xpack.observability.enableNewSyntheticsViewExperimentDescription',
-      {
-        defaultMessage:
-          'Enable new synthetic monitoring application in observability. Refresh the page to apply the setting.',
-      }
-    ),
-    schema: schema.boolean(),
-    requiresPageReload: true,
-  },
   [enableInspectEsQueries]: {
     category: [observabilityFeatureId],
     name: i18n.translate('xpack.observability.enableInspectEsQueriesExperimentName', {

x-pack/plugins/synthetics/e2e/journeys/index.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 export * from './alerts';
-export * from './synthetics';
+// export * from './synthetics';
 export * from './data_view_permissions';
 export * from './uptime.journey';
 export * from './step_duration.journey';

x-pack/plugins/synthetics/public/plugin.ts

@@ -30,7 +30,6 @@ import { DataPublicPluginSetup, DataPublicPluginStart } from '@kbn/data-plugin/p
 
 import { FleetStart } from '@kbn/fleet-plugin/public';
 import {
-  enableNewSyntheticsView,
   FetchDataParams,
   ObservabilityPublicSetup,
   ObservabilityPublicStart,
@@ -41,7 +40,6 @@ import { CasesUiStart } from '@kbn/cases-plugin/public';
 import { CloudSetup, CloudStart } from '@kbn/cloud-plugin/public';
 import { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public';
 import { PLUGIN } from '../common/constants/plugin';
-import { MONITORS_ROUTE } from '../common/constants/ui';
 import {
   LazySyntheticsPolicyCreateExtension,
   LazySyntheticsPolicyEditExtension,
@@ -195,29 +193,6 @@ export class UptimePlugin
         return renderApp(coreStart, plugins, corePlugins, params, this.initContext.env.mode.dev);
       },
     });
-
-    const isSyntheticsViewEnabled = core.uiSettings.get<boolean>(enableNewSyntheticsView);
-
-    if (isSyntheticsViewEnabled) {
-      registerSyntheticsRoutesWithNavigation(core, plugins);
-
-      // Register the Synthetics UI plugin
-      core.application.register({
-        id: 'synthetics',
-        euiIconType: 'logoObservability',
-        order: 8400,
-        title: PLUGIN.SYNTHETICS,
-        category: DEFAULT_APP_CATEGORIES.observability,
-        keywords: appKeywords,
-        deepLinks: [],
-        mount: async (params: AppMountParameters) => {
-          const [coreStart, corePlugins] = await core.getStartServices();
-
-          const { renderApp } = await import('./apps/synthetics/render_app');
-          return renderApp(coreStart, plugins, corePlugins, params, this.initContext.env.mode.dev);
-        },
-      });
-    }
   }
 
   public start(start: CoreStart, plugins: ClientPluginsStart): void {
@@ -247,40 +222,6 @@ export class UptimePlugin
 
   public stop(): void {}
 }
-
-function registerSyntheticsRoutesWithNavigation(
-  core: CoreSetup<ClientPluginsStart, unknown>,
-  plugins: ClientPluginsSetup
-) {
-  plugins.observability.navigation.registerSections(
-    from(core.getStartServices()).pipe(
-      map(([coreStart]) => {
-        if (coreStart.application.capabilities.uptime.show) {
-          return [
-            {
-              label: 'Synthetics',
-              sortKey: 499,
-              entries: [
-                {
-                  label: i18n.translate('xpack.synthetics.overview.heading', {
-                    defaultMessage: 'Monitors',
-                  }),
-                  app: 'synthetics',
-                  path: MONITORS_ROUTE,
-                  matchFullPath: true,
-                  ignoreTrailingSlash: true,
-                },
-              ],
-            },
-          ];
-        }
-
-        return [];
-      })
-    )
-  );
-}
-
 function registerUptimeRoutesWithNavigation(
   core: CoreSetup<ClientPluginsStart, unknown>,
   plugins: ClientPluginsSetup

x-pack/plugins/translations/translations/fr-FR.json

@@ -23393,8 +23393,6 @@
     "xpack.observability.enableInfrastructureViewDescription": "Activer la fonctionnalité de vue d'infrastructure dans l'application APM",
     "xpack.observability.enableInspectEsQueriesExperimentDescription": "Inspectez les recherches Elasticsearch dans les réponses API.",
     "xpack.observability.enableInspectEsQueriesExperimentName": "Inspecter les recherches ES",
-    "xpack.observability.enableNewSyntheticsViewExperimentDescription": "Activez la nouvelle application de monitoring synthétique dans Observability. Actualisez la page pour appliquer le paramètre.",
-    "xpack.observability.enableNewSyntheticsViewExperimentName": "Activer la nouvelle application de monitoring synthétique",
     "xpack.observability.enableServiceGroups": "Fonctionnalité de groupes de services",
     "xpack.observability.exp.breakDownFilter.noBreakdown": "Pas de répartition",
     "xpack.observability.exp.breakDownFilter.unavailable": "La répartition par nom d'étape n'est pas disponible pour l'indicateur de durée de monitoring. Utilisez l'indicateur de durée d'étape pour répartir par nom d'étape.",

x-pack/plugins/translations/translations/ja-JP.json

@@ -23374,8 +23374,6 @@
     "xpack.observability.enableInfrastructureViewDescription": "APMアプリでインフラストラクチャビュー機能を有効にする",
     "xpack.observability.enableInspectEsQueriesExperimentDescription": "API応答でElasticsearchクエリを調査します。",
     "xpack.observability.enableInspectEsQueriesExperimentName": "ESクエリを調査",
-    "xpack.observability.enableNewSyntheticsViewExperimentDescription": "オブザーバビリティで新しい合成監視アプリケーションを有効にします。設定を適用するにはページを更新してください。",
-    "xpack.observability.enableNewSyntheticsViewExperimentName": "新しい合成監視アプリケーションを有効にする",
     "xpack.observability.enableServiceGroups": "サービスグループ機能",
     "xpack.observability.exp.breakDownFilter.noBreakdown": "内訳なし",
     "xpack.observability.exp.breakDownFilter.unavailable": "モニター期間メトリックでは、ステップ名内訳を使用できません。ステップ期間メトリックを使用して、ステップ名で分解します。",

x-pack/plugins/translations/translations/zh-CN.json

@@ -23402,8 +23402,6 @@
     "xpack.observability.enableInfrastructureViewDescription": "在 APM 应用中启用基础架构视图功能",
     "xpack.observability.enableInspectEsQueriesExperimentDescription": "检查 API 响应中的 Elasticsearch 查询。",
     "xpack.observability.enableInspectEsQueriesExperimentName": "检查 ES 查询",
-    "xpack.observability.enableNewSyntheticsViewExperimentDescription": "在 Observability 中启用新的组合监测应用程序。刷新页面可应用该设置。",
-    "xpack.observability.enableNewSyntheticsViewExperimentName": "启用新的组合监测应用程序",
     "xpack.observability.enableServiceGroups": "服务组功能",
     "xpack.observability.exp.breakDownFilter.noBreakdown": "无细目",
     "xpack.observability.exp.breakDownFilter.unavailable": "步骤名称细目不可用于监测持续时间指标。使用步骤持续时间指标以按步骤名称细分。",

x-pack/test/functional/apps/uptime/feature_controls/uptime_security.ts

@@ -71,7 +71,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
           'Overview',
           'Alerts',
           'Uptime',
-          'Synthetics',
           'Stack Management',
         ]);
       });
@@ -124,7 +123,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
       it('shows uptime navlink', async () => {
         const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
-        expect(navLinks).to.eql(['Overview', 'Alerts', 'Uptime', 'Synthetics', 'Stack Management']);
+        expect(navLinks).to.eql(['Overview', 'Alerts', 'Uptime', 'Stack Management']);
       });
 
       it('can navigate to Uptime app', async () => {

x-pack/test/functional/config.base.js

@@ -51,7 +51,6 @@ export default async function ({ readConfigFile }) {
         '--xpack.encryptedSavedObjects.encryptionKey="DkdXazszSCYexXqz4YktBGHCRkV6hyNK"',
         '--xpack.discoverEnhanced.actions.exploreDataInContextMenu.enabled=true',
         '--savedObjects.maxImportPayloadBytes=10485760', // for OSS test management/_import_objects,
-        '--uiSettings.overrides.observability:enableNewSyntheticsView=true', // for OSS test management/_import_objects,
       ],
     },
     uiSettings: {