chore(NA): splits types from code on @kbn/analytics (#119869) (#119969)

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>

package.json

@@ -552,6 +552,7 @@
     "@types/json5": "^0.0.30",
     "@types/kbn__ace": "link:bazel-bin/packages/kbn-ace/npm_module_types",
     "@types/kbn__alerts": "link:bazel-bin/packages/kbn-alerts/npm_module_types",
+    "@types/kbn__analytics": "link:bazel-bin/packages/kbn-analytics/npm_module_types",
     "@types/kbn__i18n": "link:bazel-bin/packages/kbn-i18n/npm_module_types",
     "@types/kbn__i18n-react": "link:bazel-bin/packages/kbn-i18n-react/npm_module_types",
     "@types/license-checker": "15.0.0",

packages/BUILD.bazel

@@ -78,6 +78,7 @@ filegroup(
       "//packages/elastic-datemath:build_types",
       "//packages/kbn-ace:build_types",
       "//packages/kbn-alerts:build_types",
+      "//packages/kbn-analytics:build_types",
       "//packages/kbn-i18n:build_types",
       "//packages/kbn-i18n-react:build_types",
   ],

packages/kbn-analytics/BUILD.bazel

@@ -1,9 +1,10 @@
-load("@npm//@bazel/typescript:index.bzl", "ts_config", "ts_project")
-load("@build_bazel_rules_nodejs//:index.bzl", "js_library", "pkg_npm")
-load("//src/dev/bazel:index.bzl", "jsts_transpiler")
+load("@npm//@bazel/typescript:index.bzl", "ts_config")
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("//src/dev/bazel:index.bzl", "jsts_transpiler", "pkg_npm", "pkg_npm_types", "ts_project")
 
 PKG_BASE_NAME = "kbn-analytics"
 PKG_REQUIRE_NAME = "@kbn/analytics"
+TYPES_PKG_REQUIRE_NAME = "@types/kbn__analytics"
 
 SOURCE_FILES = glob(
   [
@@ -81,7 +82,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = RUNTIME_DEPS + [":target_node", ":target_web", ":tsc_types"],
+  deps = RUNTIME_DEPS + [":target_node", ":target_web"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )
@@ -100,3 +101,20 @@ filegroup(
   ],
   visibility = ["//visibility:public"],
 )
+
+pkg_npm_types(
+  name = "npm_module_types",
+  srcs = SRCS,
+  deps = [":tsc_types"],
+  package_name = TYPES_PKG_REQUIRE_NAME,
+  tsconfig = ":tsconfig",
+  visibility = ["//visibility:public"],
+)
+
+filegroup(
+  name = "build_types",
+  srcs = [
+    ":npm_module_types",
+  ],
+  visibility = ["//visibility:public"],
+)

packages/kbn-analytics/package.json

@@ -4,7 +4,6 @@
   "version": "1.0.0",
   "description": "Kibana Analytics tool",
   "main": "target_node/index.js",
-  "types": "target_types/index.d.ts",
   "browser": "target_web/index.js",
   "author": "Ahmad Bamieh <ahmadbamieh@gmail.com>",
   "license": "SSPL-1.0 OR Elastic License 2.0"

packages/kbn-ui-shared-deps-src/BUILD.bazel

@@ -44,7 +44,7 @@ RUNTIME_DEPS = [
 TYPES_DEPS = [
   "//packages/elastic-datemath:npm_module_types",
   "//packages/elastic-safer-lodash-set",
-  "//packages/kbn-analytics",
+  "//packages/kbn-analytics:npm_module_types",
   "//packages/kbn-babel-preset",
   "//packages/kbn-i18n:npm_module_types",
   "//packages/kbn-i18n-react:npm_module_types",

yarn.lock

@@ -5770,6 +5770,10 @@
   version "0.0.0"
   uid ""
 
+"@types/kbn__analytics@link:bazel-bin/packages/kbn-analytics/npm_module_types":
+  version "0.0.0"
+  uid ""
+
 "@types/kbn__i18n-react@link:bazel-bin/packages/kbn-i18n-react/npm_module_types":
   version "0.0.0"
   uid ""