github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[HTTP] Clean up unused generic (#156810)

Browse source 
## Summary

This PR removes an unused generic `R` from versioned route definitions.
This commit is contained in:
Jean-Louis Leysens 2023-05-07 17:40:22 +02:00 • committed by GitHub
parent f207cb5762
commit 1abd32cb3a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/core/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.ts
View file

@ -28,7 +28,7 @@ import { injectResponseHeaders } from './inject_response_headers';
import { resolvers } from './handler_resolvers';
type Options = AddVersionOpts<unknown, unknown, unknown, unknown>;
type Options = AddVersionOpts<unknown, unknown, unknown>;
// This validation is a pass-through so that we can apply our version-specific validation later
export const passThroughValidation = {

2
packages/core/http/core-http-router-server-internal/src/versioned_router/types.ts
View file

@ -26,7 +26,7 @@ export interface VersionedRouterRoute {
/** @experimental */
handlers: Array<{
fn: RequestHandler;
options: AddVersionOpts<unknown, unknown, unknown, unknown>;
options: AddVersionOpts<unknown, unknown, unknown>;
}>;
}

10
packages/core/http/core-http-server/src/versioning/types.ts
View file

@ -185,7 +185,7 @@ interface FullValidationConfig<P, Q, B> {
* of an endpoint etc.
* @experimental
*/
export interface AddVersionOpts<P, Q, B, R> {
export interface AddVersionOpts<P, Q, B> {
/**
* Version to assign to this route
* @experimental
@ -213,10 +213,8 @@ export interface VersionedRoute<
* @returns A versioned route, allows for fluent chaining of version declarations
* @experimental
*/
addVersion<P = unknown, Q = unknown, B = unknown, R = any>(
options: AddVersionOpts<P, Q, B, R>,
handler: (
...params: Parameters<RequestHandler<P, Q, B, Ctx>>
) => MaybePromise<IKibanaResponse<R>>
addVersion<P = unknown, Q = unknown, B = unknown>(
options: AddVersionOpts<P, Q, B>,
handler: (...params: Parameters<RequestHandler<P, Q, B, Ctx>>) => MaybePromise<IKibanaResponse>
): VersionedRoute<Method, Ctx>;
}