github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

[packages] migrate all plugins to packages (#148130)

Browse source 
Fixes https://github.com/elastic/kibana/issues/149344

This PR migrates all plugins to packages automatically. It does this
using `node scripts/lint_packages` to automatically migrate
`kibana.json` files to `kibana.jsonc` files. By doing this automatically
we can simplify many build and testing procedures to only support
packages, and not both "packages" and "synthetic packages" (basically
pointers to plugins).

The majority of changes are in operations related code, so we'll be
having operations review this before marking it ready for review. The
vast majority of the code owners are simply pinged because we deleted
all `kibana.json` files and replaced them with `kibana.jsonc` files, so
we plan on leaving the PR ready-for-review for about 24 hours before
merging (after feature freeze), assuming we don't have any blockers
(especially from @elastic/kibana-core since there are a few core
specific changes, though the majority were handled in #149370).

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Spencer 2023-02-08 20:06:50 -07:00 • committed by GitHub
parent 26c8d714cd
commit 1b85815402
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1044 changed files with 11279 additions and 11058 deletions
Download patch file Download diff file Expand all files Collapse all files

26
packages/kbn-repo-source-classifier-cli/index.ts
View file

@ -13,32 +13,24 @@ import { ImportResolver } from '@kbn/import-resolver';
import { REPO_ROOT } from '@kbn/repo-info';
import { getRepoFiles } from '@kbn/get-repo-files';
import { run } from '@kbn/dev-cli-runner';
import { createFlagError } from '@kbn/dev-cli-errors';
import { TypeTree } from './src/type_tree';
run(
async ({ flags }) => {
async ({ flagsReader }) => {
const resolver = ImportResolver.create(REPO_ROOT);
const classifier = new RepoSourceClassifier(resolver);
const include = flags._.length ? flags._ : [process.cwd()];
let exclude;
if (flags.exclude) {
if (Array.isArray(flags.exclude)) {
exclude = flags.exclude;
} else if (typeof flags.exclude === 'string') {
exclude = [flags.exclude];
} else {
throw createFlagError('expected --exclude value to be a string');
}
}
const include = flagsReader.getPositionals().length
? flagsReader.getPositionals().map((p) => Path.resolve(p))
: [process.cwd()];
const typeFlags = String(flags.types)
const exclude = (flagsReader.arrayOfStrings('exclude') ?? []).map((p) => Path.resolve(p));
const typeFlags = String(flagsReader.string('types'))
.split(',')
.map((f) => f.trim())
.filter(Boolean);
const includeTypes: string[] = [];
const excludeTypes: string[] = [];
for (const type of typeFlags) {
@ -60,12 +52,12 @@ run(
tree.add(type, Path.relative(cwd, abs));
}
if (!!flags.flat) {
if (flagsReader.boolean('flat')) {
for (const file of tree.toList()) {
process.stdout.write(`${file}\n`);
}
} else {
process.stdout.write(tree.print({ expand: !!flags.expand }));
process.stdout.write(tree.print({ expand: flagsReader.boolean('expand') }));
}
},
{

1
packages/kbn-repo-source-classifier-cli/tsconfig.json
View file

@ -12,7 +12,6 @@
],
"kbn_references": [
"@kbn/dev-cli-runner",
"@kbn/dev-cli-errors",
"@kbn/import-resolver",
"@kbn/repo-source-classifier",
"@kbn/get-repo-files",