github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

[APM] Fix Stackframe fontsize (#30489)

Browse source 
Decreased the font size in the code box to improve legibility.
This commit is contained in:
Casper Hübertz 2019-02-11 09:15:23 +01:00 • committed by GitHub
parent f1782b666c
commit 1bd8a22d32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
x-pack/plugins/apm/public/components/shared/Stacktrace/FrameHeading.tsx
View file

@ -9,12 +9,13 @@ import React, { Fragment } from 'react';
import styled from 'styled-components'; import styled from 'styled-components';
import { idx } from 'x-pack/plugins/apm/common/idx'; import { idx } from 'x-pack/plugins/apm/common/idx';
import { IStackframe } from 'x-pack/plugins/apm/typings/es_schemas/fields/Stackframe'; import { IStackframe } from 'x-pack/plugins/apm/typings/es_schemas/fields/Stackframe';
import { fontFamilyCode, px, units } from '../../../style/variables'; import { fontFamilyCode, fontSize, px, units } from '../../../style/variables';
const FileDetails = styled.div` const FileDetails = styled.div`
color: ${theme.euiColorMediumShade}; color: ${theme.euiColorMediumShade};
padding: ${px(units.half)}; padding: ${px(units.half)};
font-family: ${fontFamilyCode}; font-family: ${fontFamilyCode};
font-size: ${fontSize};
`; `;
const LibraryFrameFileDetail = styled.span` const LibraryFrameFileDetail = styled.span`
color: ${theme.euiColorDarkShade}; color: ${theme.euiColorDarkShade};

7
x-pack/plugins/apm/public/components/shared/Stacktrace/Stackframe.tsx
View file

@ -11,7 +11,11 @@ import {
IStackframe, IStackframe,
IStackframeWithLineContext IStackframeWithLineContext
} from 'x-pack/plugins/apm/typings/es_schemas/fields/Stackframe'; } from 'x-pack/plugins/apm/typings/es_schemas/fields/Stackframe';
import { borderRadius, fontFamilyCode } from '../../../style/variables'; import {
borderRadius,
fontFamilyCode,
fontSize
} from '../../../style/variables';
import { FrameHeading } from '../Stacktrace/FrameHeading'; import { FrameHeading } from '../Stacktrace/FrameHeading';
import { Context } from './Context'; import { Context } from './Context';
import { Variables } from './Variables'; import { Variables } from './Variables';
@ -24,6 +28,7 @@ const CodeHeader = styled.div`
const Container = styled.div<{ isLibraryFrame: boolean }>` const Container = styled.div<{ isLibraryFrame: boolean }>`
position: relative; position: relative;
font-family: ${fontFamilyCode}; font-family: ${fontFamilyCode};
font-size: ${fontSize};
border: 1px solid ${theme.euiColorLightShade}; border: 1px solid ${theme.euiColorLightShade};
border-radius: ${borderRadius}; border-radius: ${borderRadius};
background: ${props => background: ${props =>

2
x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap
View file

@ -5,6 +5,7 @@ exports[`Stackframe when stackframe has source lines should render correctly 1`]
color: rgb(152,162,179); color: rgb(152,162,179);
padding: 8px; padding: 8px;
font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace; font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace;
font-size: 14px;
} }
.c3 { .c3 {
@ -103,6 +104,7 @@ exports[`Stackframe when stackframe has source lines should render correctly 1`]
.c0 { .c0 {
position: relative; position: relative;
font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace; font-family: "SFMono-Regular",Consolas,"Liberation Mono",Menlo,Courier,monospace;
font-size: 14px;
border: 1px solid rgb(211,218,230); border: 1px solid rgb(211,218,230);
border-radius: 5px; border-radius: 5px;
background: rgb(245,247,250); background: rgb(245,247,250);