mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 18:51:07 -04:00
[SecuritySolution][Endpoint][ResponseActions] Enable response actions telemetry (#225233)
## Summary Enables feature flag to collect response actions telemetry ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Paul Tavares <paul.tavares@elastic.co>
This commit is contained in:
parent
b3573364cf
commit
1c316c1386
4 changed files with 3 additions and 12 deletions
|
@ -166,7 +166,7 @@ export const allowedExperimentalValues = Object.freeze({
|
|||
* Enables Response actions telemetry collection
|
||||
* Should be enabled in 8.17.0
|
||||
*/
|
||||
responseActionsTelemetryEnabled: false,
|
||||
responseActionsTelemetryEnabled: true,
|
||||
|
||||
/**
|
||||
* Enables experimental JAMF integration data to be available in Analyzer
|
||||
|
|
|
@ -122,6 +122,7 @@ export const createMockEndpointAppContextService = (
|
|||
const featureUsageMock = createFeatureUsageServiceMock();
|
||||
const messageSigningService = createMessageSigningServiceMock();
|
||||
const licenseServiceMock = createLicenseServiceMock();
|
||||
const telemetryServiceMock = analyticsServiceMock.createAnalyticsServiceSetup();
|
||||
|
||||
return {
|
||||
start: jest.fn(),
|
||||
|
@ -144,7 +145,7 @@ export const createMockEndpointAppContextService = (
|
|||
getExceptionListsClient: jest.fn().mockReturnValue(exceptionListsClient!),
|
||||
getMessageSigningService: jest.fn().mockReturnValue(messageSigningService),
|
||||
getFleetActionsClient: jest.fn(async (_) => fleetActionsClientMock),
|
||||
getTelemetryService: jest.fn(),
|
||||
getTelemetryService: jest.fn().mockReturnValue(telemetryServiceMock),
|
||||
getInternalResponseActionsClient: jest.fn(() => {
|
||||
return responseActionsClientMock.create();
|
||||
}),
|
||||
|
|
|
@ -557,11 +557,6 @@ describe('ResponseActionsClientImpl base class', () => {
|
|||
});
|
||||
|
||||
describe('Telemetry', () => {
|
||||
beforeEach(() => {
|
||||
// @ts-expect-error
|
||||
endpointAppContextService.experimentalFeatures.responseActionsTelemetryEnabled = true;
|
||||
});
|
||||
|
||||
it('should send action creation success telemetry for manual actions', async () => {
|
||||
await baseClassMock.writeActionRequestToEndpointIndex(indexDocOptions);
|
||||
|
||||
|
|
|
@ -916,11 +916,6 @@ describe('SentinelOneActionsClient class', () => {
|
|||
});
|
||||
|
||||
describe('Telemetry', () => {
|
||||
beforeEach(() => {
|
||||
// @ts-expect-error
|
||||
classConstructorOptions.endpointService.experimentalFeatures.responseActionsTelemetryEnabled =
|
||||
true;
|
||||
});
|
||||
describe('for Isolate and Release', () => {
|
||||
let s1ActivityHits: Array<SearchHit<SentinelOneActivityEsDoc>>;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue