github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Fix] Remove gutter from advanced settings code blocks (#32700)

Browse source 
but also add a slight left border to the gutter for other possible instances on white backgrounds
This commit is contained in:
Caroline Horn 2019-03-07 17:41:18 -05:00 • committed by GitHub
parent f96c39e492
commit 1c55034e9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap
View file

@ -1296,6 +1296,7 @@ exports[`Field for json setting should render as read only with help text if ove
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"hello\\": \\"world\\"}"
width="100%"
@ -1398,6 +1399,7 @@ exports[`Field for json setting should render custom setting icon if it is custo
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"foo\\": \\"bar\\"}"
width="100%"
@ -1535,6 +1537,7 @@ exports[`Field for json setting should render default value if there is no user
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"foo\\": \\"bar\\"}"
width="100%"
@ -1672,6 +1675,7 @@ exports[`Field for json setting should render user value if there is user value
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"hello\\": \\"world\\"}"
width="100%"
@ -1797,6 +1801,7 @@ exports[`Field for markdown setting should render as read only with help text if
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="**bold**"
width="100%"
@ -1899,6 +1904,7 @@ exports[`Field for markdown setting should render custom setting icon if it is c
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value=""
width="100%"
@ -1990,6 +1996,7 @@ exports[`Field for markdown setting should render default value if there is no u
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value=""
width="100%"
@ -2123,6 +2130,7 @@ exports[`Field for markdown setting should render user value if there is user va
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="**bold**"
width="100%"

2
src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
View file

@ -397,7 +397,7 @@ class FieldUI extends PureComponent {
editorProps={{
$blockScrolling: Infinity
}}
showGutter={false}
/>
</div>
);

5
src/legacy/ui/public/styles/_legacy/components/_ace_overrides.scss
View file

@ -44,10 +44,6 @@
overflow: visible;
}
.ace_scroller {
border-left: $euiBorderThin;
}
.ace_warning {
color: $euiColorDanger;
}
@ -70,6 +66,7 @@
.ace_gutter {
background-color: $euiColorEmptyShade;
color: $euiColorDarkShade;
border-left: 1px solid $aceBackground;
}
.ace_print-margin {