github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

do not add depvar to includes for outlier job (#120816) (#120827)

Browse source
This commit is contained in:
Melissa Alvarez 2021-12-08 16:02:48 -05:00 • committed by GitHub
parent f1856a9cfe
commit 1c75b10c8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/analysis_fields_table.tsx
View file

@ -85,6 +85,7 @@ const checkboxDisabledCheck = (item: FieldSelectionItem) =>
export const AnalysisFieldsTable: FC<{
dependentVariable?: string;
includes: string[];
isJobTypeWithDepVar: boolean;
setFormState: React.Dispatch<React.SetStateAction<any>>;
minimumFieldsRequiredMessage?: string;
setMinimumFieldsRequiredMessage: React.Dispatch<React.SetStateAction<any>>;
@ -95,6 +96,7 @@ export const AnalysisFieldsTable: FC<{
({
dependentVariable,
includes,
isJobTypeWithDepVar,
setFormState,
minimumFieldsRequiredMessage,
setMinimumFieldsRequiredMessage,
@ -120,7 +122,7 @@ export const AnalysisFieldsTable: FC<{
} else if (includes.length > 0) {
setFormState({
includes:
dependentVariable && includes.includes(dependentVariable)
(dependentVariable && includes.includes(dependentVariable)) || !isJobTypeWithDepVar
? includes
: [...includes, dependentVariable],
});
@ -234,6 +236,7 @@ export const AnalysisFieldsTable: FC<{
onTableChange={(selection: string[]) => {
// dependent variable must always be in includes
if (
isJobTypeWithDepVar &&
dependentVariable !== undefined &&
dependentVariable !== '' &&
selection.length === 0

1
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
View file

@ -670,6 +670,7 @@ export const ConfigurationStepForm: FC<ConfigurationStepProps> = ({
<AnalysisFieldsTable
dependentVariable={dependentVariable}
includes={includes}
isJobTypeWithDepVar={isJobTypeWithDepVar}
minimumFieldsRequiredMessage={minimumFieldsRequiredMessage}
setMinimumFieldsRequiredMessage={setMinimumFieldsRequiredMessage}
tableItems={firstUpdate.current ? includesTableItems : tableItems}