[8.17] [Lens] Fix getIndexPatternsObjects for index-pattern only and minor cleanups (#215325) (#217624)

# Backport This will backport the following commits from `main` to `8.17`: - [[Lens] Fix getIndexPatternsObjects for index-pattern only and minor cleanups (#215325)](https://github.com/elastic/kibana/pull/215325)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2025-04-24 01:38:56 -04:00 · 2025-04-10 09:30:40 +02:00 · 2025-04-10 09:30:40 +02:00 · 1cd15a12f3
commit 1cd15a12f3
parent 1b0d1f7623
6 changed files with 26 additions and 24 deletions
--- a/src/plugins/share/common/url_service/locators/README.md
+++ b/src/plugins/share/common/url_service/locators/README.md
@ -8,7 +8,7 @@ so the developer of the app/page has a way to change their url structure without
 breaking users of this system. If users were to generate the URLs on their own, 
 using string concatenation, those links may break often.

-Owners: __Kibana App Services team__.
+Owners: __@elastic/appex-sharedux__.


 ## Producer Usage
--- a/x-pack/plugins/lens/common/locator/locator.ts
+++ b/x-pack/plugins/lens/common/locator/locator.ts
@ -162,12 +162,12 @@ function getStateFromParams(params: LensAppLocatorParams): MainHistoryLocationSt
    return {};
  }
  const outputState: LensShareableState = {
-    activeDatasourceId: params.activeDatasourceId!,
-    visualization: params.visualization!,
+    activeDatasourceId: params.activeDatasourceId,
+    visualization: params.visualization,
    datasourceStates: Object.fromEntries(
-      Object.entries(params.datasourceStates!).map(([id, { state }]) => [id, state])
+      Object.entries(params.datasourceStates).map(([id, { state }]) => [id, state])
    ) as Record<string, { state: unknown }> & SerializableRecord,
-    references: params.references!,
+    references: params.references,
  };
  if (params.dataViewSpecs) {
    outputState.dataViewSpecs = params.dataViewSpecs;
--- a/x-pack/plugins/lens/public/embeddable/embeddable.tsx
+++ b/x-pack/plugins/lens/public/embeddable/embeddable.tsx
@ -1542,12 +1542,14 @@ export class Embeddable
    }

    const { indexPatterns } = await getIndexPatternsObjects(
-      this.savedVis?.references.map(({ id }) => id) || [],
+      this.savedVis?.references
+        .filter(({ type }) => type === 'index-pattern')
+        .map(({ id }) => id) ?? [],
      this.deps.dataViews
    );
    (
      await Promise.all(
-        Object.values(this.savedVis?.state.adHocDataViews || {}).map((spec) =>
+        Object.values(this.savedVis?.state.adHocDataViews ?? {}).map((spec) =>
          this.deps.dataViews.create(spec)
        )
      )
--- a/x-pack/plugins/lens/public/persistence/saved_object_store.ts
+++ b/x-pack/plugins/lens/public/persistence/saved_object_store.ts
@ -5,8 +5,8 @@
 * 2.0.
 */

-import { Filter, Query } from '@kbn/es-query';
-import { SavedObjectReference } from '@kbn/core/public';
+import type { Filter, Query } from '@kbn/es-query';
+import type { SavedObjectReference } from '@kbn/core/server';
 import type { DataViewSpec } from '@kbn/data-views-plugin/public';
 import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';
 import type { SearchQuery } from '@kbn/content-management-plugin/common';
--- a/x-pack/plugins/lens/public/state_management/lens_slice.ts
+++ b/x-pack/plugins/lens/public/state_management/lens_slice.ts
@ -118,25 +118,25 @@ export const getPreloadedState = ({
  const state: LensAppState = {
    ...initialState,
    isLoading: true,
+    query: query as Query,
    // Do not use app-specific filters from previous app,
    // only if Lens was opened with the intention to visualize a field (e.g. coming from Discover)
-    query: query as Query,
    filters: !initialContext
      ? data.query.filterManager.getGlobalFilters()
      : 'searchFilters' in initialContext && initialContext.searchFilters
      ? initialContext.searchFilters
      : data.query.filterManager.getFilters(),
-    searchSessionId: data.search.session.getSessionId() || '',
+    searchSessionId: data.search.session.getSessionId() ?? '',
    resolvedDateRange: getResolvedDateRange(data.query.timefilter.timefilter),
    isLinkedToOriginatingApp: Boolean(
-      embeddableEditorIncomingState?.originatingApp ||
-        (initialContext && 'isEmbeddable' in initialContext && initialContext?.isEmbeddable)
+      embeddableEditorIncomingState?.originatingApp ??
+        (initialContext && 'isEmbeddable' in initialContext && initialContext.isEmbeddable)
    ),
    activeDatasourceId: initialDatasourceId,
    datasourceStates,
    visualization: {
      state: null,
-      activeId: Object.keys(visualizationMap)[0] || null,
+      activeId: Object.keys(visualizationMap)[0] ?? null,
    },
  };
  return state;
--- a/x-pack/plugins/lens/public/utils.ts
+++ b/x-pack/plugins/lens/public/utils.ts
@ -48,7 +48,7 @@ export function getVisualizeGeoFieldMessage(fieldType: string) {
  });
 }

-export const isLensRange = (range: unknown = {}): range is RangeTypeLens => {
+export function isLensRange(range: unknown = {}): range is RangeTypeLens {
  if (!range || typeof range !== 'object') return false;
  const { from, to, label } = range as RangeTypeLens;

@ -57,23 +57,23 @@ export const isLensRange = (range: unknown = {}): range is RangeTypeLens => {
    (typeof from === 'number' || from === null) &&
    (typeof to === 'number' || to === null)
  );
-};
+}

-export const getResolvedDateRange = function (timefilter: TimefilterContract) {
+export function getResolvedDateRange(timefilter: TimefilterContract) {
  const { from, to } = timefilter.getTime();
  return { fromDate: from, toDate: to };
-};
+}

-export const getAbsoluteDateRange = function (timefilter: TimefilterContract) {
+export function getAbsoluteDateRange(timefilter: TimefilterContract) {
  const { from, to } = timefilter.getTime();
  const { min, max } = timefilter.calculateBounds({
    from,
    to,
  });
  return { fromDate: min?.toISOString() || from, toDate: max?.toISOString() || to };
-};
+}

-export const convertToAbsoluteDateRange = function (dateRange: DateRange, now: Date) {
+export function convertToAbsoluteDateRange(dateRange: DateRange, now: Date) {
  const absRange = getAbsoluteTimeRange(
    {
      from: dateRange.fromDate as string,
@ -86,7 +86,7 @@ export const convertToAbsoluteDateRange = function (dateRange: DateRange, now: D
    fromDate: absRange.from,
    toDate: absRange.to,
  };
-};
+}

 export function containsDynamicMath(dateMathString: string) {
  return dateMathString.includes('now');
@ -116,9 +116,9 @@ export function getActiveVisualizationIdFromDoc(doc?: Document) {
  return doc.visualizationType || null;
 }

-export const getInitialDatasourceId = (datasourceMap: DatasourceMap, doc?: Document) => {
+export function getInitialDatasourceId(datasourceMap: DatasourceMap, doc?: Document) {
  return (doc && getActiveDatasourceIdFromDoc(doc)) || Object.keys(datasourceMap)[0] || null;
-};
+}

 export function getInitialDataViewsObject(
  indexPatterns: IndexPatternMap,