github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Visualize] Fixes functional tests to run for vislib and es-charts (#101461)

Browse source
This commit is contained in:
Stratoula Kalafateli 2021-06-07 22:10:51 +03:00 • committed by GitHub
parent f670fd23d6
commit 1cd88f4a44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 24 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/functional/apps/visualize/_area_chart.ts
View file

@ -34,8 +34,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
describe('area charts', function indexPatternCreation() {
let isNewChartsLibraryEnabled = false;
before(async () => {
await PageObjects.visualize.initTests();
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
});
const initAreaChart = async () => {
log.debug('navigateToApp visualize');

4
test/functional/apps/visualize/_line_chart_split_chart.ts
View file

@ -25,6 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
]);
describe('line charts - split chart', function () {
let isNewChartsLibraryEnabled = false;
const initLineChart = async function () {
log.debug('navigateToApp visualize');
await PageObjects.visualize.navigateToNewAggBasedVisualization();
@ -44,7 +45,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
};
before(async () => {
await PageObjects.visualize.initTests();
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
await initLineChart();
});

4
test/functional/apps/visualize/_line_chart_split_series.ts
View file

@ -25,6 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
]);
describe('line charts - split series', function () {
let isNewChartsLibraryEnabled = false;
const initLineChart = async function () {
log.debug('navigateToApp visualize');
await PageObjects.visualize.navigateToNewAggBasedVisualization();
@ -42,7 +43,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
};
before(async () => {
await PageObjects.visualize.initTests();
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
await initLineChart();
});

11
test/functional/apps/visualize/_pie_chart.ts
View file

@ -15,8 +15,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const filterBar = getService('filterBar');
const pieChart = getService('pieChart');
const inspector = getService('inspector');
const browser = getService('browser');
const kibanaServer = getService('kibanaServer');
const PageObjects = getPageObjects([
'common',
@ -33,13 +31,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const vizName1 = 'Visualization PieChart';
before(async function () {
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests();
if (isNewChartsLibraryEnabled) {
await kibanaServer.uiSettings.update({
'visualization:visualize:legacyChartsLibrary': false,
});
await browser.refresh();
}
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
log.debug('navigateToApp visualize');
await PageObjects.visualize.navigateToNewAggBasedVisualization();
log.debug('clickPieChart');

6
test/functional/apps/visualize/_point_series_options.ts
View file

@ -60,9 +60,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.clickGo();
}
describe('vlad point series', function describeIndexTests() {
describe('point series', function describeIndexTests() {
let isNewChartsLibraryEnabled = false;
before(async () => {
await PageObjects.visualize.initTests();
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
await initChart();
});

4
test/functional/apps/visualize/_vertical_bar_chart.ts
View file

@ -19,8 +19,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['visualize', 'visEditor', 'visChart', 'timePicker']);
describe('vertical bar chart', function () {
let isNewChartsLibraryEnabled = false;
before(async () => {
await PageObjects.visualize.initTests();
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
});
const vizName1 = 'Visualization VerticalBarChart';

4
test/functional/apps/visualize/_vertical_bar_chart_nontimeindex.ts
View file

@ -18,6 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('vertical bar chart with index without time filter', function () {
const vizName1 = 'Visualization VerticalBarChart without time filter';
let isNewChartsLibraryEnabled = false;
const initBarChart = async () => {
log.debug('navigateToApp visualize');
@ -40,7 +41,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
};
before(async () => {
await PageObjects.visualize.initTests();
isNewChartsLibraryEnabled = await PageObjects.visChart.isNewChartsLibraryEnabled();
await PageObjects.visualize.initTests(isNewChartsLibraryEnabled);
await initBarChart();
});

3
test/functional/page_objects/visualize_page.ts
View file

@ -47,13 +47,14 @@ export class VisualizePageObject extends FtrService {
LOGSTASH_NON_TIME_BASED: 'logstash*',
};
public async initTests() {
public async initTests(isNewLibrary = false) {
await this.kibanaServer.savedObjects.clean({ types: ['visualization'] });
await this.kibanaServer.importExport.load('visualize');
await this.kibanaServer.uiSettings.replace({
defaultIndex: 'logstash-*',
[UI_SETTINGS.FORMAT_BYTES_DEFAULT_PATTERN]: '0,0.[000]b',
'visualization:visualize:legacyChartsLibrary': !isNewLibrary,
});
}

2
test/functional/services/visualizations/pie_chart.ts
View file

@ -42,7 +42,7 @@ export class PieChartService extends FtrService {
const pieWidth = pieSize.width;
await pie.clickMouseButton({
xOffset: pieSlice.coords[0] - Math.floor(pieWidth / 2),
yOffset: Math.floor(pieHeight / 2) - pieSlice.coords[1],
yOffset: pieSlice.coords[1] - Math.floor(pieHeight / 2),
});
}
} else {