[APM] Enable Operations Breakdown by default (#148305)

## Summary

closes: https://github.com/elastic/kibana/issues/147682


https://user-images.githubusercontent.com/3369346/210387189-41423215-b17e-49b3-a84b-4e080ad4fc5b.mov

1. Enables Operations Breakdown 
2. Removes the advanced setting for the operations
3. Passes the params
This commit is contained in:
Katerina Patticha 2023-01-03 17:57:16 +01:00 committed by GitHub
parent 2dbbd8a304
commit 1d0a8c9ddd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 30 additions and 88 deletions

View file

@ -526,10 +526,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
type: 'keyword',
_meta: { description: 'Default value of the setting was changed.' },
},
'observability:apmOperationsTab': {
type: 'boolean',
_meta: { description: 'Non-default value of setting.' },
},
'observability:apmLabsButton': {
type: 'boolean',
_meta: { description: 'Non-default value of setting.' },

View file

@ -142,7 +142,6 @@ export interface UsageStats {
isDefaultIndexMigrated: boolean;
'lens:useFieldExistenceSampling': boolean;
'metrics:allowCheckingForFailedShards': boolean;
'observability:apmOperationsTab': boolean;
'observability:apmLabsButton': boolean;
'observability:enableAwsLambdaMetrics': boolean;
'observability:apmProgressiveLoading': string;

View file

@ -9048,12 +9048,6 @@
"description": "Default value of the setting was changed."
}
},
"observability:apmOperationsTab": {
"type": "boolean",
"_meta": {
"description": "Non-default value of setting."
}
},
"observability:apmLabsButton": {
"type": "boolean",
"_meta": {

View file

@ -27,7 +27,8 @@ export function FlyoutTopLevelProperties({ transaction }: Props) {
const { query } = useAnyOfApmParams(
'/services/{serviceName}/transactions/view',
'/mobile-services/{serviceName}/transactions/view',
'/traces/explorer'
'/traces/explorer',
'/dependencies/operation'
);
const latencyAggregationType =

View file

@ -35,7 +35,8 @@ export function WaterfallFlyout({
query: { flyoutDetailTab },
} = useAnyOfApmParams(
'/services/{serviceName}/transactions/view',
'/mobile-services/{serviceName}/transactions/view'
'/mobile-services/{serviceName}/transactions/view',
'/dependencies/operation'
);
const currentItem = waterfall.items.find(
(item) => item.id === waterfallItemId

View file

@ -86,6 +86,7 @@ export const dependencies = {
sampleRangeFrom: toNumberRt,
sampleRangeTo: toNumberRt,
waterfallItemId: t.string,
flyoutDetailTab: t.string,
}),
]),
}),

View file

@ -16,7 +16,6 @@ import { useApmParams } from '../../../hooks/use_apm_params';
import { useApmRouter } from '../../../hooks/use_apm_router';
import { useApmRoutePath } from '../../../hooks/use_apm_route_path';
import { useFetcher } from '../../../hooks/use_fetcher';
import { useOperationBreakdownEnabledSetting } from '../../../hooks/use_operations_breakdown_enabled_setting';
import { useTimeRange } from '../../../hooks/use_time_range';
import { BetaBadge } from '../../shared/beta_badge';
import { SearchBar } from '../../shared/search_bar';
@ -39,9 +38,6 @@ export function DependencyDetailTemplate({ children }: Props) {
const path = useApmRoutePath();
const isOperationsBreakdownFeatureEnabled =
useOperationBreakdownEnabledSetting();
const kueryBarBoolFilter = getKueryBarBoolFilter({
environment,
dependencyName,
@ -68,33 +64,31 @@ export function DependencyDetailTemplate({ children }: Props) {
const { data: { metadata } = {} } = dependencyMetadataFetch;
const tabs = isOperationsBreakdownFeatureEnabled
? [
{
key: 'overview',
href: router.link('/dependencies/overview', {
query,
}),
label: i18n.translate('xpack.apm.DependencyDetailOverview.title', {
defaultMessage: 'Overview',
}),
isSelected: path === '/dependencies/overview',
},
{
key: 'operations',
href: router.link('/dependencies/operations', {
query,
}),
label: i18n.translate('xpack.apm.DependencyDetailOperations.title', {
defaultMessage: 'Operations',
}),
isSelected:
path === '/dependencies/operations' ||
path === '/dependencies/operation',
append: <BetaBadge icon="beta" />,
},
]
: [];
const tabs = [
{
key: 'overview',
href: router.link('/dependencies/overview', {
query,
}),
label: i18n.translate('xpack.apm.DependencyDetailOverview.title', {
defaultMessage: 'Overview',
}),
isSelected: path === '/dependencies/overview',
},
{
key: 'operations',
href: router.link('/dependencies/operations', {
query,
}),
label: i18n.translate('xpack.apm.DependencyDetailOperations.title', {
defaultMessage: 'Operations',
}),
isSelected:
path === '/dependencies/operations' ||
path === '/dependencies/operation',
append: <BetaBadge icon="beta" />,
},
];
return (
<ApmMainTemplate

View file

@ -1,15 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { apmOperationsTab } from '@kbn/observability-plugin/common';
import { useApmPluginContext } from '../context/apm_plugin/use_apm_plugin_context';
export function useOperationBreakdownEnabledSetting() {
const { core } = useApmPluginContext();
return core.uiSettings.get<boolean>(apmOperationsTab, false);
}

View file

@ -21,7 +21,6 @@ export {
apmServiceInventoryOptimizedSorting,
apmServiceGroupMaxNumberOfServices,
apmTraceExplorerTab,
apmOperationsTab,
apmLabsButton,
enableInfrastructureHostsView,
enableAwsLambdaMetrics,

View file

@ -16,7 +16,6 @@ export const apmServiceInventoryOptimizedSorting =
export const apmServiceGroupMaxNumberOfServices =
'observability:apmServiceGroupMaxNumberOfServices';
export const apmTraceExplorerTab = 'observability:apmTraceExplorerTab';
export const apmOperationsTab = 'observability:apmOperationsTab';
export const apmLabsButton = 'observability:apmLabsButton';
export const enableInfrastructureHostsView = 'observability:enableInfrastructureHostsView';
export const enableAwsLambdaMetrics = 'observability:enableAwsLambdaMetrics';

View file

@ -19,7 +19,6 @@ import {
enableNewSyntheticsView,
apmServiceGroupMaxNumberOfServices,
apmTraceExplorerTab,
apmOperationsTab,
apmLabsButton,
enableAgentExplorerView,
enableAwsLambdaMetrics,
@ -29,10 +28,6 @@ import {
enableInfrastructureHostsView,
} from '../common/ui_settings_keys';
const betaLabel = i18n.translate('xpack.observability.uiSettings.betaLabel', {
defaultMessage: 'beta',
});
const technicalPreviewLabel = i18n.translate(
'xpack.observability.uiSettings.technicalPreviewLabel',
{ defaultMessage: 'technical preview' }
@ -220,25 +215,6 @@ export const uiSettings: Record<string, UiSettings> = {
type: 'boolean',
showInLabs: true,
},
[apmOperationsTab]: {
category: [observabilityFeatureId],
name: i18n.translate('xpack.observability.apmOperationsBreakdown', {
defaultMessage: 'APM Operations Breakdown',
}),
description: i18n.translate('xpack.observability.apmOperationsBreakdownDescription', {
defaultMessage:
'{betaLabel} Enable the APM Operations Breakdown feature, that displays aggregates for backend operations. {feedbackLink}.',
values: {
betaLabel: `<em>[${betaLabel}]</em>`,
feedbackLink: feedbackLink({ href: 'https://ela.st/feedback-operations-breakdown' }),
},
}),
schema: schema.boolean(),
value: true,
requiresPageReload: true,
type: 'boolean',
showInLabs: false,
},
[apmLabsButton]: {
category: [observabilityFeatureId],
name: i18n.translate('xpack.observability.apmLabs', {

View file

@ -24615,7 +24615,6 @@
"xpack.observability.apmAWSLambdaRequestCostPerMillion": "Prix AWS Lambda pour 1M de requêtes",
"xpack.observability.apmLabs": "Activer le bouton Ateliers dans APM",
"xpack.observability.apmLabsDescription": "Cet indicateur détermine si l'utilisateur a accès au bouton Ateliers, moyen rapide d'activer et de désactiver les fonctionnalités de la version d'évaluation technique dans APM.",
"xpack.observability.apmOperationsBreakdown": "Répartition des opérations APM",
"xpack.observability.apmProgressiveLoading": "Utiliser le chargement progressif des vues APM sélectionnées",
"xpack.observability.apmProgressiveLoadingQualityHigh": "Taux d'échantillonnage élevé (plus lent, plus précis)",
"xpack.observability.apmProgressiveLoadingQualityLow": "Taux d'échantillonnage bas (plus rapide, moins précis)",

View file

@ -24594,7 +24594,6 @@
"xpack.observability.apmAWSLambdaRequestCostPerMillion": "1MリクエストごとのAWS Lambdaの料金",
"xpack.observability.apmLabs": "APMでラボボタンを有効にする",
"xpack.observability.apmLabsDescription": "このフラグはビューアーでラボボタンを使用できるかどうかを決定します。APMでテクニカルプレビュー中の機能を有効および無効にするための簡単な方法です。",
"xpack.observability.apmOperationsBreakdown": "APM演算内訳",
"xpack.observability.apmProgressiveLoading": "選択したAPMビューのプログレッシブ読み込みを使用",
"xpack.observability.apmProgressiveLoadingQualityHigh": "高サンプリングレート(低速、最も精度が高い)",
"xpack.observability.apmProgressiveLoadingQualityLow": "低サンプリングレート(最速、最も精度が低い)",

View file

@ -24624,7 +24624,6 @@
"xpack.observability.apmAWSLambdaRequestCostPerMillion": "AWS lambda 每 1M 请求的价格",
"xpack.observability.apmLabs": "在 APM 中启用“实验”按钮",
"xpack.observability.apmLabsDescription": "此标志决定查看者是否有权访问用于在 APM 中快速启用和禁用技术预览功能的“实验”按钮。",
"xpack.observability.apmOperationsBreakdown": "APM Operations Breakdown",
"xpack.observability.apmProgressiveLoading": "使用渐进方式加载选定 APM 视图",
"xpack.observability.apmProgressiveLoadingQualityHigh": "高采样速率(更慢,最准确)",
"xpack.observability.apmProgressiveLoadingQualityLow": "低采样速率(最快,最不准确)",