github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Obs AI Assistant] Fix null pointer in function definition (#203344)

Browse source 
Closes #201713
This commit is contained in:
Søren Louv-Jansen 2024-12-09 15:00:05 +01:00 • committed by GitHub
parent cafab5eb64
commit 1d9ca1ebf6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/packages/kbn-ai-assistant/src/hooks/use_json_editor_model.ts
View file

@ -43,7 +43,7 @@ export const useJsonEditorModel = ({
const initialJsonString = initialJsonValue
? JSON.stringify(safeJsonParse(initialJsonValue), null, 4) // prettify the json
: functionDefinition.parameters.properties
: functionDefinition.parameters?.properties
? JSON.stringify(createInitializedObject(functionDefinition.parameters), null, 4)
: '';

2
x-pack/packages/kbn-ai-assistant/src/utils/create_initialized_object.ts
View file

@ -7,7 +7,7 @@
import type { FunctionDefinition } from '@kbn/observability-ai-assistant-plugin/common';
type Params = FunctionDefinition['parameters'];
type Params = NonNullable<FunctionDefinition['parameters']>;
export function createInitializedObject(parameters: Params) {
const emptyObject: Record<string, string | any> = {};

4
x-pack/plugins/observability_solution/observability_ai_assistant/common/functions/types.ts
View file

@ -35,7 +35,9 @@ export type FunctionResponse =
}
| Observable<ChatCompletionChunkEvent | MessageAddEvent>;
export interface FunctionDefinition<TParameters extends CompatibleJSONSchema = any> {
export interface FunctionDefinition<
TParameters extends CompatibleJSONSchema = CompatibleJSONSchema
> {
name: string;
description: string;
visibility?: FunctionVisibility;

9
x-pack/plugins/observability_solution/observability_ai_assistant_app/server/functions/query/index.ts
View file

@ -5,7 +5,7 @@
* 2.0.
*/
import { isChatCompletionChunkEvent, isOutputEvent } from '@kbn/inference-common';
import { ToolDefinition, isChatCompletionChunkEvent, isOutputEvent } from '@kbn/inference-common';
import { correctCommonEsqlMistakes } from '@kbn/inference-plugin/common';
import { naturalLanguageToEsql } from '@kbn/inference-plugin/server';
import {
@ -132,9 +132,10 @@ export function registerQueryFunction({
),
logger: resources.logger,
tools: Object.fromEntries(
actions
.concat(esqlFunctions)
.map((fn) => [fn.name, { description: fn.description, schema: fn.parameters }])
[...actions, ...esqlFunctions].map((fn) => [
fn.name,
{ description: fn.description, schema: fn.parameters } as ToolDefinition,
])
),
functionCalling: useSimulatedFunctionCalling ? 'simulated' : 'native',
});